Add welcome window (with Terms and Conditions) #106

Merged
kernelwhisperer merged 4 commits from feature/115-user-agreement-window into master 2018-05-15 04:06:14 -04:00
kernelwhisperer commented 2018-05-12 10:06:26 -04:00 (Migrated from github.com)

What changed?

Instead of the loading window, now we show the welcome window (which ToS) until you have accepted them.

Fixes: https://dev.siderus.team/issues/115

## What changed? Instead of the loading window, now we show the welcome window (which ToS) until you have accepted them. Fixes: https://dev.siderus.team/issues/115
koalalorenzo (Migrated from github.com) requested changes 2018-05-12 10:10:33 -04:00
@ -0,0 +1,31 @@
import React from 'react'
koalalorenzo (Migrated from github.com) commented 2018-05-12 10:09:30 -04:00

We should probably fetch this content from an URL to be always sure to have the latest content.
https://siderus.io/tos.html

We should probably fetch this content from an URL to be always sure to have the latest content. https://siderus.io/tos.html
kernelwhisperer (Migrated from github.com) reviewed 2018-05-14 08:38:40 -04:00
@ -0,0 +1,31 @@
import React from 'react'
kernelwhisperer (Migrated from github.com) commented 2018-05-14 08:38:39 -04:00

Refused to display 'https://siderus.io/tos.html' in a frame because it set 'X-Frame-Options' to 'deny'

We need to allow CORS.

> Refused to display 'https://siderus.io/tos.html' in a frame because it set 'X-Frame-Options' to 'deny' We need to allow CORS.
koalalorenzo (Migrated from github.com) reviewed 2018-05-14 10:34:38 -04:00
@ -0,0 +1,31 @@
import React from 'react'
koalalorenzo (Migrated from github.com) commented 2018-05-14 10:34:38 -04:00

Will a download work? You don’t need to use an iFrame, but we could download the content and then display it. What do you say?

Will a _download_ work? You don’t need to use an iFrame, but we could download the content and then display it. What do you say?
kernelwhisperer (Migrated from github.com) reviewed 2018-05-14 16:15:42 -04:00
@ -0,0 +1,31 @@
import React from 'react'
kernelwhisperer (Migrated from github.com) commented 2018-05-14 16:15:42 -04:00

Updated. We should keep in mind though that it relies on an internet connection, but I guess that shouldn't be a problem.

Updated. We should keep in mind though that it relies on an internet connection, but I guess that shouldn't be a problem.
koalalorenzo (Migrated from github.com) reviewed 2018-05-14 23:27:25 -04:00
@ -0,0 +1,31 @@
import React from 'react'
koalalorenzo (Migrated from github.com) commented 2018-05-14 23:27:25 -04:00

Yes, it already relies on it due to the Siderus Network

Yes, it already relies on it due to the Siderus Network
koalalorenzo (Migrated from github.com) requested changes 2018-05-15 00:20:28 -04:00
@ -0,0 +1,89 @@
import React from 'react'
koalalorenzo (Migrated from github.com) commented 2018-05-14 23:40:32 -04:00

Change to "I have read and I agree to Siderus Terms and Conditions and Privacy policy"

Can in case change the Terms and Conditions and Privacy Policy to links that will open in the browser? :S

Change to "I have read and I agree to Siderus Terms and Conditions and Privacy policy" Can in case change the Terms and Conditions and Privacy Policy to links that will open in the browser? :S
koalalorenzo (Migrated from github.com) approved these changes 2018-05-15 03:28:50 -04:00
koalalorenzo (Migrated from github.com) left a comment

Well done 👍

Well done 👍
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!106
No description provided.