Add option to disable the tray icon #108

2018-05-15T10:55:28-04:00

kernelwhisperer commented

2018-05-15 10:55:28 -04:00

(Migrated from github.com)

What changed?

Added a one-time notification when you first close the app to let the user know it will run the background.
Added setting to enable/disable the tray icon

## What changed? - Added a one-time notification when you first close the app to let the user know it will run the background. - Added setting to enable/disable the tray icon

koalalorenzo (Migrated from github.com) requested changes

2018-05-15 15:41:30 -04:00

app/index.js

					
				@ -294,3 +294,28 @@ app.on('will-quit', () => {

				    global.IPFS_PROCESS.kill()

This will trigger the message every time the settings is false, try with a more specific setup:
systemTrayNotification === undefined

This will trigger the message every time the settings is `false`, try with a more specific setup: `systemTrayNotification === undefined`

app/windows/Settings/Components/AppPanel.jsx

Do we really need a new panel for one option? Can we add it to the Daemon settings?

kernelwhisperer (Migrated from github.com) reviewed

2018-05-16 05:36:21 -04:00

app/windows/Settings/Components/AppPanel.jsx

I've added it to the connectivity panel, we don't have a daemon panel anymore

koalalorenzo (Migrated from github.com) approved these changes

2018-05-16 13:17:35 -04:00

koalalorenzo (Migrated from github.com) left a comment

LGTM 🔥 👍

Sign in to join this conversation.

No reviewers

koalalorenzo

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Siderus/Orion!108

				`@ -294,3 +294,28 @@ app.on('will-quit', () => {`
				`global.IPFS_PROCESS.kill()`

Rows
Columns