Siderus/Orion
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

Add option to publish to IPNS #117

Merged
kernelwhisperer merged 7 commits from feature/8-publish-to-ipns into master 2018-05-26 17:44:55 -04:00
Conversation 6 Commits 7 Files changed 9 +298 -5
kernelwhisperer commented 2018-05-23 11:39:22 -04:00 (Migrated from github.com)
Copy link

What changed?

Added Publish to IPNS window and Publish to IPNS to the StorageElement's menu.

## What changed? Added Publish to IPNS window and Publish to IPNS to the StorageElement's menu.
koalalorenzo (Migrated from github.com) requested changes 2018-05-23 12:19:15 -04:00
app/menu.js
@ -20,3 +21,3 @@
label: 'Resolve IPNS',
accelerator: 'CmdOrCtrl+E',
accelerator: 'CmdOrCtrl+F',
click () {
koalalorenzo (Migrated from github.com) commented 2018-05-23 12:17:47 -04:00
Copy link

I would invert Resolve (aka Find) and Publish:

  • CmdOrCTRL+F => Resolve
  • CmdOrCTRL+E => Publush

Does it make more sense? otherwise lets find something else. CMD+P? (used for Print, but what do we have to print? :P )

I would invert Resolve (aka Find) and Publish: - CmdOrCTRL+F => Resolve - CmdOrCTRL+E => Publush Does it make more sense? otherwise lets find something else. CMD+P? (used for Print, but what do we have to print? :P )
koalalorenzo (Migrated from github.com) commented 2018-05-23 12:18:00 -04:00
Copy link

Add spaces, Publish to IPNS

Add spaces, `Publish to IPNS`
koalalorenzo (Migrated from github.com) requested changes 2018-05-23 13:38:50 -04:00
app/windows/PublishToIPNS/renderer.jsx
@ -0,0 +1,116 @@
import React from 'react'
koalalorenzo (Migrated from github.com) commented 2018-05-23 13:38:46 -04:00
Copy link

What if we add a line that is saying that this process may take few minutes?

What if we add a line that is saying that this process may take few minutes?
koalalorenzo (Migrated from github.com) requested changes 2018-05-23 13:41:43 -04:00
app/windows/PublishToIPNS/renderer.jsx
@ -0,0 +1,116 @@
import React from 'react'
koalalorenzo (Migrated from github.com) commented 2018-05-23 13:40:42 -04:00
Copy link

For some reason I cannot copy this. Should we add a button to copy the ID in the clipboard?
(Same issue goes in the settings)

For some reason I cannot copy this. Should we add a button to copy the ID in the clipboard? (Same issue goes in the settings)
koalalorenzo (Migrated from github.com) commented 2018-05-23 13:41:39 -04:00
Copy link

Should we add the IPNS hash instead?
Something like IPNS ${peer id} has been successfully updated to ${result.value}?

Should we add the IPNS hash instead? Something like `IPNS ${peer id} has been successfully updated to ${result.value}`?
koalalorenzo commented 2018-05-24 15:18:35 -04:00 (Migrated from github.com)
Copy link

I have spent my last 30 min trying to understand what is wrong here:

screen shot 2018-05-24 at 21 17 55

:O

I have spent my last 30 min trying to understand what is wrong here: <img width="563" alt="screen shot 2018-05-24 at 21 17 55" src="https://user-images.githubusercontent.com/33528/40507517-fb620aa2-5f97-11e8-909c-b1f0afa97dba.png"> :O
kernelwhisperer commented 2018-05-25 05:12:55 -04:00 (Migrated from github.com)
Copy link

That's the error we get from ipfs when the hash is an empty string, not very nice...
The problem was how the hash was retrieved, should be working now.

That's the error we get from ipfs when the hash is an empty string, not very nice... The problem was how the hash was retrieved, should be working now.
koalalorenzo (Migrated from github.com) approved these changes 2018-05-25 12:07:44 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
koalalorenzo
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!117
No description provided.