Siderus/Orion
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

Upgrade to electron 2.0 + dependencies #137

Merged
koalalorenzo merged 4 commits from feature/upgrade-el-2.0 into master 2018-06-11 02:57:58 -04:00
Conversation 6 Commits 4 Files changed 16 +298 -276
koalalorenzo commented 2018-06-10 14:00:42 -04:00 (Migrated from github.com)
Copy link

What changed?

  • Upgrades the electron version to 2.0.2
  • Upgrades all the dependencies to the latest release (according to limits in package.json)
  • Moves reporting snippets into app/lib/report and divides the code for preload and node setup
  • Fixes popup() missing object due to electron 2.0.2
## What changed? - Upgrades the electron version to 2.0.2 - Upgrades all the dependencies to the latest release (according to limits in `package.json`) - Moves reporting snippets into `app/lib/report` and divides the code for `preload` and `node` setup - Fixes `popup()` missing object due to electron 2.0.2
koalalorenzo commented 2018-06-10 14:50:41 -04:00 (Migrated from github.com)
Copy link

Secondary/Right click on elements seems not to work anymore.

Secondary/Right click on elements seems not to work anymore.
koalalorenzo commented 2018-06-10 17:00:46 -04:00 (Migrated from github.com)
Copy link

The popup menu API changed: https://github.com/electron/electron/issues/12915
Fixed now

The popup menu API changed: https://github.com/electron/electron/issues/12915 Fixed now
koalalorenzo commented 2018-06-10 17:01:06 -04:00 (Migrated from github.com)
Copy link

This upgrade also changes the way Sentry is loaded: preload now changes compared to normal javascript files (outside window)

This upgrade also changes the way Sentry is loaded: preload now changes compared to normal javascript files (outside window)
koalalorenzo commented 2018-06-10 17:04:40 -04:00 (Migrated from github.com)
Copy link

Ready for review: please test it a lot 😅

Ready for review: please test it _a lot_ 😅
kernelwhisperer commented 2018-06-11 02:55:43 -04:00 (Migrated from github.com)
Copy link

I've tested all the windows, it looks good! 👍
The only thing I found was something unrelated:
image
The number of peers never loads. I looked into the code and it seems that we race the promises. I will open a new issue for this.

I've tested all the windows, it looks good! :+1: The only thing I found was something unrelated: ![image](https://user-images.githubusercontent.com/26041347/41216486-3e694b6c-6d5d-11e8-9290-eb6b3bc2421a.png) The number of peers never loads. I looked into the code and it seems that we race the promises. I will open a new issue for this.
👍 1
kernelwhisperer (Migrated from github.com) approved these changes 2018-06-11 02:55:56 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
kernelwhisperer
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!137
No description provided.