Siderus/Orion
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

Add row selection to StorageList #150

Merged
kernelwhisperer merged 3 commits from 4-as-a-user-i-want-to-highlight-the-elements-in-the-list-so-i-can-select-multiple into master 2018-07-14 03:32:54 -04:00
Conversation 4 Commits 3 Files changed 2 +53 -7
kernelwhisperer commented 2018-07-10 07:30:28 -04:00 (Migrated from github.com)
Copy link

What changed?

Fixed #134 and point 4 and 5 from #130.

## What changed? Fixed #134 and point 4 and 5 from #130.
koalalorenzo (Migrated from github.com) requested changes 2018-07-10 12:01:41 -04:00
koalalorenzo (Migrated from github.com) left a comment
Copy link

It seems that is always removing the "latest" selected, when I untick a check. (See attached gif)

It seems that is always removing the "latest" selected, when I untick a check. (See attached gif)
app/windows/Storage/Components/StorageElement.jsx
@ -92,25 +92,63 @@ class StorageElement extends React.Component {
this.menu.popup({})
koalalorenzo (Migrated from github.com) commented 2018-07-10 11:59:37 -04:00
Copy link

Delete the lines, don't comment them: we have git history for that :)

Delete the lines, don't comment them: we have git history for that :)
koalalorenzo commented 2018-07-10 12:02:38 -04:00 (Migrated from github.com)
Copy link

This is what I was talking about

2018-07-10 18_01_43

This is what I was talking about ![2018-07-10 18_01_43](https://user-images.githubusercontent.com/33528/42522443-65e2324c-846b-11e8-9214-fbe8407fb3ae.gif)
koalalorenzo commented 2018-07-14 03:32:02 -04:00 (Migrated from github.com)
Copy link

LGTM

LGTM
koalalorenzo (Migrated from github.com) approved these changes 2018-07-14 03:32:05 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
koalalorenzo
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!150
No description provided.