Siderus/Orion
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

Dont clear ongoing activities #175

Merged
kernelwhisperer merged 4 commits from feature/dont-clear-ongoing-activities into master 2018-08-15 05:25:36 -04:00
Conversation 9 Commits 4 Files changed 2 +89 -4
kernelwhisperer commented 2018-08-14 04:30:22 -04:00 (Migrated from github.com)
Copy link

What changed?

Insert here the changes.

## What changed? Insert here the changes.
koalalorenzo commented 2018-08-14 09:55:05 -04:00 (Migrated from github.com)
Copy link

Should we add some tests about this?

Should we add some tests about this?
koalalorenzo (Migrated from github.com) requested changes 2018-08-14 09:56:09 -04:00
koalalorenzo (Migrated from github.com) left a comment
Copy link

Should we add some tests if possible?

Should we add some tests if possible?
koalalorenzo (Migrated from github.com) approved these changes 2018-08-15 03:27:49 -04:00
koalalorenzo (Migrated from github.com) requested changes 2018-08-15 03:28:11 -04:00
app/index.js
@ -362,9 +362,38 @@ ipcMain.on('update-activities', () => {
updateActivitiesWindow()
koalalorenzo (Migrated from github.com) commented 2018-08-15 03:28:07 -04:00
Copy link

can we add more comments?

can we add more comments?
koalalorenzo (Migrated from github.com) reviewed 2018-08-15 03:28:38 -04:00
app/index.js
@ -362,9 +362,38 @@ ipcMain.on('update-activities', () => {
updateActivitiesWindow()
koalalorenzo (Migrated from github.com) commented 2018-08-15 03:28:38 -04:00
Copy link

We need a little more documentations on what this is doing for future works

We need a little more documentations on what this is doing for future works
kernelwhisperer (Migrated from github.com) reviewed 2018-08-15 03:34:12 -04:00
app/index.js
@ -362,9 +362,38 @@ ipcMain.on('update-activities', () => {
updateActivitiesWindow()
kernelwhisperer (Migrated from github.com) commented 2018-08-15 03:34:11 -04:00
Copy link

Yep, good idea 🌮

Yep, good idea :taco:
kernelwhisperer (Migrated from github.com) reviewed 2018-08-15 03:39:09 -04:00
app/index.js
@ -362,9 +362,38 @@ ipcMain.on('update-activities', () => {
updateActivitiesWindow()
kernelwhisperer (Migrated from github.com) commented 2018-08-15 03:39:09 -04:00
Copy link

Does this make more sense?

Does this make more sense?
koalalorenzo (Migrated from github.com) reviewed 2018-08-15 03:46:34 -04:00
app/index.js
@ -362,9 +362,38 @@ ipcMain.on('update-activities', () => {
updateActivitiesWindow()
koalalorenzo (Migrated from github.com) commented 2018-08-15 03:46:33 -04:00
Copy link

Yes! :D

Yes! :D
koalalorenzo (Migrated from github.com) approved these changes 2018-08-15 03:46:41 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
koalalorenzo
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!175
No description provided.