Siderus/Orion
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

Ensure userData dir exists #178

Merged
kernelwhisperer merged 2 commits from bugfix/cannot-find-settings-file into master 2018-08-20 08:36:17 -04:00
Conversation 4 Commits 2 Files changed 1 +13
kernelwhisperer commented 2018-08-19 05:44:26 -04:00 (Migrated from github.com)
Copy link

What changed?

Added logic to make sure the userdata dir exists before electron settings is called

To reproduce it, I deleted ~/.config/Orion, ran make build_unpacked and opened the app

## What changed? Added logic to make sure the userdata dir exists before electron settings is called To reproduce it, I deleted `~/.config/Orion`, ran `make build_unpacked` and opened the app
koalalorenzo (Migrated from github.com) reviewed 2018-08-19 05:47:17 -04:00
app/index.js
koalalorenzo (Migrated from github.com) commented 2018-08-19 05:47:01 -04:00
Copy link

Should we add this in the index.js or in the entry.js? Where does it make more sense?

Should we add this in the `index.js` or in the `entry.js`? Where does it make more sense?
kernelwhisperer (Migrated from github.com) reviewed 2018-08-19 05:58:29 -04:00
app/index.js
kernelwhisperer (Migrated from github.com) commented 2018-08-19 05:58:29 -04:00
Copy link

Just tested and both approaches work, I don't have a preference tbh. What do you think?

Just tested and both approaches work, I don't have a preference tbh. What do you think?
koalalorenzo (Migrated from github.com) reviewed 2018-08-19 10:23:05 -04:00
app/index.js
koalalorenzo (Migrated from github.com) commented 2018-08-19 10:23:05 -04:00
Copy link

I think we can move the whole code in to entry.js and keep everything that should run as a preparation there as it is the file that is starting everything

I think we can move the whole code in to `entry.js` and keep everything that should run as a preparation there as it is the file that is starting everything
koalalorenzo (Migrated from github.com) approved these changes 2018-08-20 08:36:08 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
koalalorenzo
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!178
No description provided.