Siderus/Orion
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

Add the context menu after the welcome window #179

Merged
kernelwhisperer merged 5 commits from feature/add-context-menu-automatically into master 2018-08-21 03:11:04 -04:00
Conversation 5 Commits 5 Files changed 4 +25 -38
kernelwhisperer commented 2018-08-21 01:58:38 -04:00 (Migrated from github.com)
Copy link

What changed?

Insert here the changes.

## What changed? Insert here the changes.
koalalorenzo (Migrated from github.com) requested changes 2018-08-21 02:16:00 -04:00
koalalorenzo (Migrated from github.com) left a comment
Copy link

Should we remove the element from the settings to turn on and off this feature?

Should we remove the element from the settings to turn on and off this feature?
app/index.js
koalalorenzo (Migrated from github.com) commented 2018-08-21 02:15:31 -04:00
Copy link

Should we move this function into app/lib?

Should we move this function into `app/lib`?
kernelwhisperer commented 2018-08-21 02:30:12 -04:00 (Migrated from github.com)
Copy link

But then there would be absolutely no way to remove it, do we want that?

But then there would be absolutely no way to remove it, do we want that?
koalalorenzo commented 2018-08-21 02:40:02 -04:00 (Migrated from github.com)
Copy link

We will add a new task to add a way to remove it. I feel we need to make a new section in the Settings :D

We will add a new task to add a way to remove it. I feel we need to make a new section in the Settings :D
koalalorenzo (Migrated from github.com) requested changes 2018-08-21 02:41:21 -04:00
app/index.js
koalalorenzo (Migrated from github.com) commented 2018-08-21 02:41:01 -04:00
Copy link

Can we add a small comment here? What is this doing here? :)

Can we add a small comment here? What is this doing here? :)
app/windows/Settings/Components/ConnectivityPanel.jsx
@ -5,7 +5,6 @@ import { trackEvent } from '../../../stats'
koalalorenzo (Migrated from github.com) commented 2018-08-21 02:41:16 -04:00
Copy link

<3 <3 <3

<3 <3 <3
koalalorenzo (Migrated from github.com) approved these changes 2018-08-21 03:07:04 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
koalalorenzo
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!179
No description provided.