Save IPFS_CLIENT correctly #99

Merged

kernelwhisperer merged 1 commit from bugfix/119-storage-list-connects-forever into master

2018-05-07 15:29:06 -04:00

kernelwhisperer commented

2018-05-07 05:52:24 -04:00

(Migrated from github.com)

What changed?

IPFS_CLIENT is saved correctly now.

The problem was how we called initIPFSClient which resulted in global.IPFS_CLIENT being undefined, hence, the remotes were initializing IPFS client themselves instead of sharing the instance from the main process. Which should work (and sometimes does after you trigger some other API call, like adding a file), but not always because of the remotes not using promiseIPFSReady after init, like we use in index.js

This fixes: https://dev.siderus.team/issues/119

## What changed? IPFS_CLIENT is saved correctly now. The problem was how we called `initIPFSClient` which resulted in `global.IPFS_CLIENT` being `undefined`, hence, the remotes were initializing IPFS client themselves instead of sharing the instance from the main process. Which should work (and sometimes does after you trigger some other API call, like adding a file), but not always because of the remotes not using `promiseIPFSReady` after init, like we use in `index.js` This fixes: https://dev.siderus.team/issues/119

koalalorenzo (Migrated from github.com) approved these changes

2018-05-07 08:59:43 -04:00

koalalorenzo commented

2018-05-07 15:29:01 -04:00

(Migrated from github.com)

Tested on macOS - latest and Ubuntu - 16.04

No reviewers

koalalorenzo

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Siderus/Orion!99

No description provided.

Rows
Columns