TwiN/go-away
1
0
Fork 0
Code Issues 8 Pull requests 2 Projects Releases 38 Packages Wiki Activity Actions

Duplicate false negatives and profanities break censoring #31

New issue
Closed
opened 2022-05-01 16:47:13 -04:00 by TwiN · 0 comments
TwiN commented 2022-05-01 16:47:13 -04:00 (Migrated from github.com)
Copy link

Describe the bug

When a string has two false negatives and two profanities, the string is not censored properly.

What do you see?

println(goaway.Censor("document fuck document fuck"))

outputs

document **** ****ment fuck

For verbosity, note that by default, document is a false positive (meaning it should not be censored) and fuck is a profanity.

What do you expect to see?

The output should be:

document **** document ****

List the steps that must be taken to reproduce this issue

  1. Uncomment the test case that can be found at TwiN/go-away@3bf4c7a7e9/goaway_test.go (L148-L152)
  2. Run the tests
  3. Note how the new test case is failing

Version

v1.6.3

Additional information

I found this out while investigating #30

### Describe the bug When a string has two false negatives and two profanities, the string is not censored properly. ### What do you see? ```go println(goaway.Censor("document fuck document fuck")) ``` outputs ``` document **** ****ment fuck ``` For verbosity, note that by default, `document` is a false positive (meaning it should not be censored) and `fuck` is a profanity. ### What do you expect to see? The output should be: ``` document **** document **** ``` ### List the steps that must be taken to reproduce this issue 1. Uncomment the test case that can be found at https://github.com/TwiN/go-away/blob/3bf4c7a7e93678e0190ee33dc588d7e87eae609a/goaway_test.go#L148-L152 2. Run the tests 3. Note how the new test case is failing ### Version v1.6.3 ### Additional information I found this out while investigating #30
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/github_actions/actions/checkout-6
v1.8.1
v1.8.0
v1.7.0
v1.6.16
v1.6.15
v1.6.14
v1.6.13
v1.6.12
v1.6.11
v1.6.10
v1.6.9
v1.6.8
v1.6.7
v1.6.6
v1.6.5
v1.6.4
v1.6.3
v1.6.2
v1.6.1
v1.6.0
v1.5.0
v1.4.1
v1.4.0
v1.3.0
v1.2.1
v1.2.0
v1.1.4
v1.1.3
v1.1.2
v1.1.1
v1.1.0
v1.0.1
v1.0.0
v0.0.5
v0.0.4
v0.0.3
v0.0.2
v0.0.1
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
TwiN/go-away#31
No description provided.