TwiN/go-away
1
0
Fork 0
Code Issues 8 Pull requests 2 Projects Releases 38 Packages Wiki Activity Actions

Add analy and assist in list of default false positives #35

Merged
tbantle22 merged 1 commit from patch-2 into master 2022-06-23 19:26:16 -04:00
Conversation 4 Commits 1 Files changed 1 +2
tbantle22 commented 2022-06-23 19:18:46 -04:00 (Migrated from github.com)
Copy link
No description provided.
codecov-commenter commented 2022-06-23 19:21:33 -04:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #35 (49d410e) into master (8998110) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files           1        1           
  Lines         191      191           
=======================================
  Hits          190      190           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8998110...49d410e. Read the comment docs.

# [Codecov](https://codecov.io/gh/TwiN/go-away/pull/35?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.) Report > Merging [#35](https://codecov.io/gh/TwiN/go-away/pull/35?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.) (49d410e) into [master](https://codecov.io/gh/TwiN/go-away/commit/8998110b8c6e70ecb17ed0cc2d1885d8acac65e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.) (8998110) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #35 +/- ## ======================================= Coverage 99.47% 99.47% ======================================= Files 1 1 Lines 191 191 ======================================= Hits 190 190 Misses 1 1 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/TwiN/go-away/pull/35?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/TwiN/go-away/pull/35?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.). Last update [8998110...49d410e](https://codecov.io/gh/TwiN/go-away/pull/35?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.).
TwiN (Migrated from github.com) reviewed 2022-06-23 19:25:36 -04:00
falsepositives.go
@ -2,12 +2,14 @@ package goaway
// DefaultFalsePositives is a list of words that may wrongly trigger the DefaultProfanities
var DefaultFalsePositives = []string{
"analy", // analysis, analytics
TwiN (Migrated from github.com) commented 2022-06-23 19:25:36 -04:00
Copy link

To be honest, this one could probably be abused (even if the proper way to type it would be anally), but we'd have to add analyz for analyze, analyt for analytics and analys for analysis, so I guess we'll just go with analy as you've suggested.

Ultimately, users are free to provide their own list of false positives, so it shouldn't be too much of a big deal.

To be honest, this one could probably be abused (even if the proper way to type it would be `anally`), but we'd have to add `analyz` for analyze, `analyt` for analytics and `analys` for analysis, so I guess we'll just go with `analy` as you've suggested. Ultimately, users are free to provide their own list of false positives, so it shouldn't be too much of a big deal.
TwiN (Migrated from github.com) approved these changes 2022-06-23 19:25:41 -04:00
TwiN commented 2022-06-23 19:27:38 -04:00 (Migrated from github.com)
Copy link

Thank you for the contribution!

Released in v1.6.6.

Thank you for the contribution! Released in [v1.6.6](https://github.com/TwiN/go-away/releases/tag/v1.6.6).
Sign in to join this conversation.
Reviewers
No reviewers
TwiN
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
TwiN/go-away!35
No description provided.