cathayddt/bdk
1
0
Fork 0
Code Issues 14 Pull requests Projects Releases 20 Packages Wiki Activity Actions

feat: Support selecting nodes to deploy contracts #129

Merged
madhuLin merged 15 commits from feature/3.3.1 into 3.3.1 2025-07-28 10:14:20 -04:00
Conversation 4 Commits 15 Files changed 12 +38 -18
madhuLin commented 2025-07-23 05:30:26 -04:00 (Migrated from github.com)
Copy link

PULL REQUEST

Before

說明 (Description)

✨ Features

  • The contract deployment function supports selecting the node to deploy

🐛 Bug Fixes

  • Fixed the issue where the Quorum chain was mistakenly established when quickly establishing the Besu chain

📝 Documentation

  • Fixed the example contract error in the 3.3.0 file

相關問題 (Linked Issues)

因 GitHub runner 環境近期變動，導致 Hyperledger Fabric 相關測試在 CI 執行時產生版本或相依性錯誤。目前暫時註解掉部分與 Fabric 測試或腳本有關的程式碼。

🔧 Commented Lines

  • cicd/test-script/ca.sh: Line 145
  • cicd/test-script/cryptogen.sh: Line 28

🚫 Skipped Tests

  • test/fabric/service/channel.test.ts
    • should update channel config
    • should decode fetched channel config
    • should update channel by envelope

貢獻種類 (Type of change)

  • Bug fix (除錯 non-breaking change which fixes an issue)
  • New feature (增加新功能 non-breaking change which adds functionality)
  • Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected)
  • Doc change (需要更新文件 this change requires a documentation update)

測試環境 (Test Configuration):

  • OS: Linux 5.15 (WSL2)
  • NodeJS Version: 18.13.0
  • NPM Version: 8.19.3
  • Docker Version: 27.3.1

檢查清單 (Checklist):

  • 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project)
  • 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code)
  • 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas)
  • 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation)
  • 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings)
  • 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works)
  • 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings)

我已完成以上清單，並且同意遵守 Code of Conduct

I have completed the checklist and agree to abide by the code of conduct.

  • 同意 (I consent)
# PULL REQUEST ## Before <!-- Please check the one that applies to this PR using "x". --> - [x] 遵守 Commit 規範 (follow [commit convention](https://github.com/cathayddt/bdk/blob/master/.github/COMMIT_CONVENTION.md)) - [x] 遵守 Contributing 規範 (follow [contributing](https://github.com/cathayddt/bdk/blob/master/.github/CONTRIBUTING.md)) ## 說明 (Description) <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> <!--請簡單說明此PR的更動、被修復的問題以及相關的原因，並請列出這個更動所需要的任何相依模組/套件。 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.--> ✨ Features - The contract deployment function supports selecting the node to deploy 🐛 Bug Fixes - Fixed the issue where the Quorum chain was mistakenly established when quickly establishing the Besu chain 📝 Documentation - Fixed the example contract error in the 3.3.0 file ## 相關問題 (Linked Issues) <!-- - Related issues linked `fixes #number` - Tests added. Pass Coverage. - Errors have a helpful link. --> 因 GitHub runner 環境近期變動，導致 Hyperledger Fabric 相關測試在 CI 執行時產生版本或相依性錯誤。目前暫時註解掉部分與 Fabric 測試或腳本有關的程式碼。 ### 🔧 Commented Lines - `cicd/test-script/ca.sh`: Line 145 - `cicd/test-script/cryptogen.sh`: Line 28 ### 🚫 Skipped Tests - `test/fabric/service/channel.test.ts` - `should update channel config` - `should decode fetched channel config` - `should update channel by envelope` ## 貢獻種類 (Type of change) - [x] Bug fix (除錯 non-breaking change which fixes an issue) - [x] New feature (增加新功能 non-breaking change which adds functionality) - [ ] Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected) - [x] Doc change (需要更新文件 this change requires a documentation update) **測試環境 (Test Configuration)**: * OS: Linux 5.15 (WSL2) * NodeJS Version: 18.13.0 * NPM Version: 8.19.3 * Docker Version: 27.3.1 ## 檢查清單 (Checklist): - [x] 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project) - [x] 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code) - [x] 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas) - [x] 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation) - [x] 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings) - [x] 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works) - [x] 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings) 我已完成以上清單，並且同意遵守 [Code of Conduct](CODE_OF_CONDUCT.md) I have completed the checklist and agree to abide by the [code of conduct](CODE_OF_CONDUCT.md). - [x] 同意 (I consent)
kth-tw (Migrated from github.com) reviewed 2025-07-23 05:30:26 -04:00
Yorkchung commented 2025-07-24 23:28:01 -04:00 (Migrated from github.com)
Copy link

Remember to update README.md and CHANGELOG.md.

Remember to update README.md and CHANGELOG.md.
Yorkchung commented 2025-07-24 23:29:13 -04:00 (Migrated from github.com)
Copy link

package.json and package-lock.json also needs to be updated.

package.json and package-lock.json also needs to be updated.
Yorkchung (Migrated from github.com) approved these changes 2025-07-28 10:11:41 -04:00
src/eth/command/contract/deploy.ts
@ -82,10 +82,17 @@ export const handler = async (argv: Arguments<OptType>) => {
message: 'What is the account private key of deploy contract?',
Yorkchung (Migrated from github.com) commented 2025-07-24 23:16:58 -04:00
Copy link

I recommend changing this variable to rpcUrl.

I recommend changing this variable to rpcUrl.
Sign in to join this conversation.
Reviewers
No reviewers
kth-tw
Yorkchung
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cathayddt/bdk!129
No description provided.