cathayddt/bdk
1
0
Fork 0
Code Issues 14 Pull requests Projects Releases 20 Packages Wiki Activity Actions

3.4.0 - feat: fabric channel snapshot #132

Merged
casper-ubereats merged 23 commits from 3.4.2 into 3.4.0 2025-08-13 03:28:42 -04:00
Conversation 4 Commits 23 Files changed 20 +786 -22
casper-ubereats commented 2025-07-29 02:36:01 -04:00 (Migrated from github.com)
Copy link

PULL REQUEST

Before

說明 (Description)

  1. 新增snapshot command，其中包含4個operation: submitSnapshot, listPending, cancelRequest, joinBySnapshot

相關問題 (Linked Issues)

貢獻種類 (Type of change)

  • Bug fix (除錯 non-breaking change which fixes an issue)
  • New feature (增加新功能 non-breaking change which adds functionality)
  • Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected)
  • Doc change (需要更新文件 this change requires a documentation update)

測試環境 (Test Configuration):

  • OS: Linux
  • NodeJS Version: 18.18.2
  • NPM Version: 9.8.1
  • Docker Version: 27.4.0

檢查清單 (Checklist):

  • 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project)
  • 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code)
  • 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas)
  • 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation)
  • 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings)
  • 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works)
  • 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings)

我已完成以上清單，並且同意遵守 Code of Conduct

I have completed the checklist and agree to abide by the code of conduct.

  • 同意 (I consent)
# PULL REQUEST ## Before <!-- Please check the one that applies to this PR using "x". --> - [x] 遵守 Commit 規範 (follow [commit convention](https://github.com/cathayddt/bdk/blob/master/.github/COMMIT_CONVENTION.md)) - [x] 遵守 Contributing 規範 (follow [contributing](https://github.com/cathayddt/bdk/blob/master/.github/CONTRIBUTING.md)) ## 說明 (Description) <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> 1. 新增snapshot command，其中包含4個operation: submitSnapshot, listPending, cancelRequest, joinBySnapshot <!--請簡單說明此PR的更動、被修復的問題以及相關的原因，並請列出這個更動所需要的任何相依模組/套件。 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.--> ## 相關問題 (Linked Issues) <!-- - Related issues linked `fixes #number` - Tests added. Pass Coverage. - Errors have a helpful link. --> ## 貢獻種類 (Type of change) - [x] Bug fix (除錯 non-breaking change which fixes an issue) - [x] New feature (增加新功能 non-breaking change which adds functionality) - [x] Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected) - [x] Doc change (需要更新文件 this change requires a documentation update) **測試環境 (Test Configuration)**: * OS: Linux * NodeJS Version: 18.18.2 * NPM Version: 9.8.1 * Docker Version: 27.4.0 ## 檢查清單 (Checklist): - [x] 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project) - [x] 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code) - [x] 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas) - [x] 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation) - [x] 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings) - [x] 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works) - [x] 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings) 我已完成以上清單，並且同意遵守 [Code of Conduct](CODE_OF_CONDUCT.md) I have completed the checklist and agree to abide by the [code of conduct](CODE_OF_CONDUCT.md). - [x] 同意 (I consent)
kth-tw (Migrated from github.com) reviewed 2025-07-29 02:36:01 -04:00
Yorkchung (Migrated from github.com) reviewed 2025-08-12 05:03:27 -04:00
src/fabric/instance/fabricInstance.ts
@ -391,4 +391,79 @@ export default class FabricInstance extends AbstractInstance {
undefined,
Yorkchung (Migrated from github.com) commented 2025-08-12 04:39:12 -04:00
Copy link

No need to print this line.

No need to print this line.
src/fabric/service/channel.ts
@ -427,4 +436,80 @@ export default class Channel extends AbstractService {
public listJoinedChannel = async (): Promise<InfraRunnerResultType> => {
Yorkchung (Migrated from github.com) commented 2025-08-12 04:49:40 -04:00
Copy link

Lack of error handling.

Lack of error handling.
Yorkchung (Migrated from github.com) commented 2025-08-12 04:50:18 -04:00
Copy link

Lack of error handling.

Lack of error handling.
Yorkchung (Migrated from github.com) commented 2025-08-12 04:51:05 -04:00
Copy link

Lack of error handling.

Lack of error handling.
Yorkchung (Migrated from github.com) commented 2025-08-12 04:51:34 -04:00
Copy link

Lack of error handling.

Lack of error handling.
Yorkchung (Migrated from github.com) reviewed 2025-08-12 05:31:56 -04:00
CHANGELOG.md
@ -3,6 +3,28 @@
這份文件將記錄 BDK 專案的變更日誌
Yorkchung (Migrated from github.com) commented 2025-08-12 05:31:50 -04:00
Copy link

Add 4 snapshot commands: submitSnapshot, listPending, cancelRequest, joinBySnapshot

Add 4 snapshot commands: submitSnapshot, listPending, cancelRequest, joinBySnapshot
src/fabric/service/channel.ts
@ -427,4 +436,80 @@ export default class Channel extends AbstractService {
public listJoinedChannel = async (): Promise<InfraRunnerResultType> => {
Yorkchung (Migrated from github.com) commented 2025-08-12 05:22:50 -04:00
Copy link

Remove unnecessary comments

Remove unnecessary comments
Yorkchung (Migrated from github.com) reviewed 2025-08-13 02:27:22 -04:00
src/fabric/command/channel/snapshot.ts
@ -0,0 +1,148 @@
import { Argv, Arguments } from 'yargs'
Yorkchung (Migrated from github.com) commented 2025-08-13 02:23:33 -04:00
Copy link

Use errorHandler(error as Error)

Use `errorHandler(error as Error)`
src/fabric/service/channel.ts
@ -427,4 +436,80 @@ export default class Channel extends AbstractService {
public listJoinedChannel = async (): Promise<InfraRunnerResultType> => {
Yorkchung (Migrated from github.com) commented 2025-08-13 02:26:52 -04:00
Copy link

Use a custom SnapshotError error

Use a custom `SnapshotError` error
Yorkchung (Migrated from github.com) commented 2025-08-13 02:27:01 -04:00
Copy link

Use a custom SnapshotError error

Use a custom `SnapshotError` error
Yorkchung (Migrated from github.com) commented 2025-08-13 02:27:08 -04:00
Copy link

Use a custom SnapshotError error

Use a custom `SnapshotError` error
Yorkchung (Migrated from github.com) commented 2025-08-13 02:27:17 -04:00
Copy link

Use a custom SnapshotError error

Use a custom `SnapshotError` error
Sign in to join this conversation.
Reviewers
No reviewers
kth-tw
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cathayddt/bdk!132
No description provided.