cathayddt/bdk
1
0
Fork 0
Code Issues 14 Pull requests Projects Releases 20 Packages Wiki Activity Actions

Logger output level "stdout" "stderr" #30

Merged
SecondDim merged 5 commits from issue-22 into master 2021-12-15 21:05:30 -05:00
Conversation 3 Commits 5 Files changed 30 +308 -181
SecondDim commented 2021-12-14 22:59:15 -05:00 (Migrated from github.com)
Copy link

PULL REQUEST

說明 (Description)

  • Reactor logger freamwork
  • update typescript version to 4.5

相關問題 (Linked Issues)

貢獻種類 (Type of change)

  • Bug fix (除錯 non-breaking change which fixes an issue)
  • New feature (增加新功能 non-breaking change which adds functionality)
  • Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected)
  • Doc change (需要更新文件 this change requires a documentation update)

測試環境 (Test Configuration):

  • OS: mac
  • NodeJS Version: 16.13
  • NPM Version: 8
  • Docker Version: 20

檢查清單 (Checklist):

  • 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project)
  • 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code)
  • 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas)
  • 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation)
  • 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings)
  • 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works)
  • 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings)

我已完成以上清單，並且同意遵守 Code of Conduct

I have completed the checklist and agree to abide by the code of conduct.

  • 同意 (I consent)
# PULL REQUEST ## 說明 (Description) - Reactor logger freamwork - update typescript version to 4.5 ## 相關問題 (Linked Issues) - #22 ## 貢獻種類 (Type of change) - [ ] Bug fix (除錯 non-breaking change which fixes an issue) - [ ] New feature (增加新功能 non-breaking change which adds functionality) - [X] Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected) - [ ] Doc change (需要更新文件 this change requires a documentation update) **測試環境 (Test Configuration)**: * OS: mac * NodeJS Version: 16.13 * NPM Version: 8 * Docker Version: 20 ## 檢查清單 (Checklist): - [x] 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project) - [x] 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code) - [x] 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas) - [ ] 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation) - [ ] 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings) - [ ] 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works) - [x] 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings) 我已完成以上清單，並且同意遵守 [Code of Conduct](CODE_OF_CONDUCT.md) I have completed the checklist and agree to abide by the [code of conduct](CODE_OF_CONDUCT.md). - [x] 同意 (I consent)
RuiSiang (Migrated from github.com) reviewed 2021-12-14 22:59:15 -05:00
kth-tw (Migrated from github.com) reviewed 2021-12-15 00:43:04 -05:00
src/instance/infra/docker/runner.ts
@ -30,4 +28,2 @@
}
public runCommand = async (payload: DockerRunCommandType): Promise<DockerResultType> => {
await this.checkAndCreateNetwork(payload.network)
kth-tw (Migrated from github.com) commented 2021-12-15 00:42:58 -05:00
Copy link

cathayddt/bdk@d63e7a4338/src/config.ts (L46)
cathayddt/bdk@d63e7a4338/cicd/test_script/ca-gen.sh (L5)
cathayddt/bdk@d63e7a4338/cicd/test_script/crypto-gen.sh (L5)
cathayddt/bdk@d63e7a4338/src/model/type/config.type.ts (L19)
cathayddt/bdk@d63e7a4338/src/service/config.ts (L14)
這些都可以拿掉了

https://github.com/cathayddt/bdk/blob/d63e7a43381ac03950fe55e86a7efcede1d863e9/src/config.ts#L46 https://github.com/cathayddt/bdk/blob/d63e7a43381ac03950fe55e86a7efcede1d863e9/cicd/test_script/ca-gen.sh#L5 https://github.com/cathayddt/bdk/blob/d63e7a43381ac03950fe55e86a7efcede1d863e9/cicd/test_script/crypto-gen.sh#L5 https://github.com/cathayddt/bdk/blob/d63e7a43381ac03950fe55e86a7efcede1d863e9/src/model/type/config.type.ts#L19 https://github.com/cathayddt/bdk/blob/d63e7a43381ac03950fe55e86a7efcede1d863e9/src/service/config.ts#L14 這些都可以拿掉了
kth-tw (Migrated from github.com) approved these changes 2021-12-15 20:52:38 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
RuiSiang
kth-tw
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cathayddt/bdk!30
No description provided.