修復使用 bdk ca up 啟動 ICA 時，不會使用設定到期時間 #41

2021-12-22T22:13:38-05:00

RuiSiang commented

2021-12-22 22:13:38 -05:00

(Migrated from github.com)

PULL REQUEST

說明 (Description)

修復使用 bdk ca up 啟動 ICA 時，不會使用設定到期時間

貢獻種類 (Type of change)

Bug fix (除錯 non-breaking change which fixes an issue)
New feature (增加新功能 non-breaking change which adds functionality)
Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected)
Doc change (需要更新文件 this change requires a documentation update)

測試環境 (Test Configuration):

OS:
NodeJS Version:
NPM Version:
Docker Version:

檢查清單 (Checklist):

我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project)
我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code)
我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas)
我有在文件中進行必要的更動 (I have made corresponding changes to the documentation)
我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings)
我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works)
我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings)

我已完成以上清單，並且同意遵守 Code of Conduct

I have completed the checklist and agree to abide by the code of conduct.

同意 (I consent)

# PULL REQUEST ## 說明 (Description) 修復使用 bdk ca up 啟動 ICA 時，不會使用設定到期時間 ## 相關問題 (Linked Issues) - #39 ## 貢獻種類 (Type of change) - [x] Bug fix (除錯 non-breaking change which fixes an issue) - [ ] New feature (增加新功能 non-breaking change which adds functionality) - [ ] Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected) - [ ] Doc change (需要更新文件 this change requires a documentation update) **測試環境 (Test Configuration)**: * OS: * NodeJS Version: * NPM Version: * Docker Version: ## 檢查清單 (Checklist): - [x] 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project) - [x] 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code) - [x] 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas) - [x] 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation) - [x] 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings) - [x] 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works) - [x] 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings) 我已完成以上清單，並且同意遵守 [Code of Conduct](CODE_OF_CONDUCT.md) I have completed the checklist and agree to abide by the [code of conduct](CODE_OF_CONDUCT.md). - [x] 同意 (I consent)

kth-tw (Migrated from github.com) requested changes

2021-12-23 20:00:22 -05:00

kth-tw (Migrated from github.com) left a comment

-i要改（現在ica不會問這些問題）
這幾個參數要不要改名？
cathayddt/bdk@e1e7a53e68/src/command/ca/up.ts (L96-L113)

1. `-i`要改（現在ica不會問這些問題） 2. 這幾個參數要不要改名？ https://github.com/cathayddt/bdk/blob/e1e7a53e6859ec5e6b8de8b250de65e628e88533/src/command/ca/up.ts#L96-L113

kth-tw (Migrated from github.com) requested changes

2022-01-06 00:34:19 -05:00

src/command/ca/up.ts

					
				@ -111,3 +110,4 @@

				      describe: '(CSR) Pathlength for CSR if this is an CA',

				      type: 'number',

				      default: 0,

				    },