cathayddt/bdk
1
0
Fork 0
Code Issues 14 Pull requests Projects Releases 20 Packages Wiki Activity Actions

refactor: channelService fetchChannelConfig have default signType value #58

Merged
kth-tw merged 1 commit from refactor-fetchChannelConfig into master 2022-02-14 21:38:44 -05:00
Conversation 2 Commits 1 Files changed 3 +6 -7
kth-tw commented 2022-02-14 04:37:14 -05:00 (Migrated from github.com)
Copy link

PULL REQUEST

說明 (Description)

大部分情況下，signType都是吃this.config.orgType，將此值設為預設值

相關問題 (Linked Issues)

貢獻種類 (Type of change)

  • Bug fix (除錯 non-breaking change which fixes an issue)
  • New feature (增加新功能 non-breaking change which adds functionality)
  • Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected)
  • Doc change (需要更新文件 this change requires a documentation update)

測試環境 (Test Configuration):

  • OS:
  • NodeJS Version:
  • NPM Version:
  • Docker Version:

檢查清單 (Checklist):

  • 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project)
  • 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code)
  • 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas)
  • 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation)
  • 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings)
  • 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works)
  • 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings)

我已完成以上清單，並且同意遵守 Code of Conduct

I have completed the checklist and agree to abide by the code of conduct.

  • 同意 (I consent)
# PULL REQUEST ## 說明 (Description) 大部分情況下，`signType`都是吃`this.config.orgType`，將此值設為預設值 ## 相關問題 (Linked Issues) ## 貢獻種類 (Type of change) - [ ] Bug fix (除錯 non-breaking change which fixes an issue) - [ ] New feature (增加新功能 non-breaking change which adds functionality) - [ ] Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected) - [ ] Doc change (需要更新文件 this change requires a documentation update) **測試環境 (Test Configuration)**: * OS: * NodeJS Version: * NPM Version: * Docker Version: ## 檢查清單 (Checklist): - [ ] 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project) - [ ] 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code) - [ ] 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas) - [ ] 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation) - [ ] 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings) - [ ] 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works) - [ ] 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings) 我已完成以上清單，並且同意遵守 [Code of Conduct](CODE_OF_CONDUCT.md) I have completed the checklist and agree to abide by the [code of conduct](CODE_OF_CONDUCT.md). - [ ] 同意 (I consent)
RuiSiang (Migrated from github.com) reviewed 2022-02-14 04:37:14 -05:00
SecondDim (Migrated from github.com) approved these changes 2022-02-14 21:29:52 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
RuiSiang
SecondDim
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cathayddt/bdk!58
No description provided.