Custom download folders

nianeyna commented

2024-05-29 22:25:08 -04:00

(Migrated from github.com)

Discussed in https://github.com/nianeyna/ao3downloader/discussions/134

^{Originally posted by shrnt May 16, 2024}
Hi, thanks a lot, this has been a life saver!!

It would be nice if I could specify the download folder. I'd like to download all my bookmarks and all my Marked For Later, but I don't want them to be in the same shared folder. I read in another reply you mentioned that you don't wanna download out of the ao3downloader folder for security reasons, so maybe something like ao3downloader/downloads/bookmarks or ao3downloader/downloads/customfoldername

I guess for now, I could interchange the ao3downloader/downloads folder whenever I want to download/update either my Bookmarks or Marked for Later. But it would be convenient if I could specify the destination folder each time before the download starts. Or maybe even be able to define the folders in the settings.json

Thanks again!

### Discussed in https://github.com/nianeyna/ao3downloader/discussions/134 <div type='discussions-op-text'> <sup>Originally posted by **shrnt** May 16, 2024</sup> Hi, thanks a lot, this has been a life saver!! It would be nice if I could specify the download folder. I'd like to download all my bookmarks and all my Marked For Later, but I don't want them to be in the same shared folder. I read in another reply you mentioned that you don't wanna download out of the ao3downloader folder for security reasons, so maybe something like `ao3downloader/downloads/bookmarks` or `ao3downloader/downloads/customfoldername` I guess for now, I could interchange the `ao3downloader/downloads` folder whenever I want to download/update either my Bookmarks or Marked for Later. But it would be convenient if I could specify the destination folder each time before the download starts. Or maybe even be able to define the folders in the `settings.json` Thanks again!</div>

alexmaul commented

2025-01-24 06:42:44 -05:00

(Migrated from github.com)

Hi! Thank you for this great script! :D

I was about to build something like that myself when my partner found your's -- saved me a lot of work, which I could invest in contributing, if that's something you'd consider accepting.

The matter of custom download folders / sub-folder interested me the most (at the moment, at least).
I'd find it very useful to sort all works belonging to series into sub-folders (one per series) while all other works can stay in the main download folder.

Would it be ok if I send you a pull request for my extension?
Do you have requirements for the code-style?

AlexM

Hi! Thank you for this great script! :D I was about to build something like that myself when my partner found your's -- saved me a lot of work, which I could invest in contributing, if that's something you'd consider accepting. The matter of custom download folders / sub-folder interested me the most (at the moment, at least). I'd find it very useful to sort all works belonging to series into sub-folders (one per series) while all other works can stay in the main download folder. Would it be ok if I send you a pull request for my extension? Do you have requirements for the code-style? AlexM

nianeyna commented

2025-01-24 17:59:09 -05:00

(Migrated from github.com)

@alexmaul I do accept PRs but of course I may ask for changes or decide not to accept it, and do please keep them as small and atomic as possible since otherwise it's a lot of work for me to review. As far as code style goes just use your judgement and try to match what's already there as much as possible.

Regarding sub-folders, there's actually a separate issue open for that ( #183 ) so please keep that separate from any PRs for this issue, which is for specifying a different root folder location to download to. Also, if you're going to work on subfolders I'd like to discuss it first since there are a few problems/considerations around that that I want to make sure are addressed.

Thanks for your interest in the project!

@alexmaul I do accept PRs but of course I may ask for changes or decide not to accept it, and do please keep them as small and atomic as possible since otherwise it's a lot of work for me to review. As far as code style goes just use your judgement and try to match what's already there as much as possible. Regarding sub-folders, there's actually a separate issue open for that ( #183 ) so please keep that separate from any PRs for this issue, which is for specifying a different *root* folder location to download to. Also, if you're going to work on subfolders I'd like to discuss it first since there are a few problems/considerations around that that I want to make sure are addressed. Thanks for your interest in the project!

alexmaul commented

2025-01-28 01:37:46 -05:00

(Migrated from github.com)

Thank you for the quick response and beeing open for PRs :)

The PR I prepared actually shows to solve (or at least tries to) issue #183, so we should move any discussion over there, if not to the PR?

AlexM

Thank you for the quick response and beeing open for PRs :) The PR I prepared actually shows to solve (or at least tries to) issue #183, so we should move any discussion over there, if not to the PR? AlexM

Rows
Columns

Custom download folders #139

Discussed in https://github.com/nianeyna/ao3downloader/discussions/134