pankod/next-boilerplate
1
0
Fork 0
Code Issues 3 Pull requests 34 Projects Releases Packages Wiki Activity Actions

Drop custom css #123

Merged
BatuhanW merged 9 commits from drop-custom-css into master 2020-10-05 03:11:55 -04:00
Conversation 8 Commits 9 Files changed 9 +220 -965
BatuhanW commented 2020-10-04 11:38:20 -04:00 (Migrated from github.com)
Copy link

Fixes #120

Fixes #120
mhrrmk (Migrated from github.com) reviewed 2020-10-04 11:38:20 -04:00
yildirayunlu (Migrated from github.com) reviewed 2020-10-04 11:38:20 -04:00
aliemir (Migrated from github.com) reviewed 2020-10-04 11:38:20 -04:00
biskuvit (Migrated from github.com) reviewed 2020-10-04 11:38:20 -04:00
necatiozmen (Migrated from github.com) reviewed 2020-10-04 11:38:20 -04:00
BatuhanW (Migrated from github.com) reviewed 2020-10-04 11:44:07 -04:00
.storybook/main.js
@ -37,2 +50,4 @@
"sass-loader",
],
});
BatuhanW (Migrated from github.com) commented 2020-10-04 11:41:55 -04:00
Copy link

Excluding module.scss files so they won't be processed with these loaders. Since we don't have modules: true option here, it will fail to load module.scss files.

Keeping it here, because we still need to process css, scss files without modules.

Excluding `module.scss` files so they won't be processed with these loaders. Since we don't have `modules: true` option here, it will fail to load `module.scss` files. Keeping it here, because we still need to process `css, scss` files without modules.
.storybook/main.js
BatuhanW (Migrated from github.com) commented 2020-10-04 11:42:15 -04:00
Copy link

Provide modules: true so *.module.scss files will be handled gracefully.

Provide `modules: true` so `*.module.scss` files will be handled gracefully.
BatuhanW (Migrated from github.com) reviewed 2020-10-04 11:48:12 -04:00
src/Components/Heading/__snapshots__/index.spec.tsx.snap
@ -15,3 +9,3 @@
>
<span>
Test
</span>
BatuhanW (Migrated from github.com) commented 2020-10-04 11:48:12 -04:00
Copy link

https://spectrum.chat/testing-library/help-react/trouble-testing-styles-with-css-modules~70414090-2fea-41a2-be5a-50b16c221214

https://spectrum.chat/testing-library/help-react/trouble-testing-styles-with-css-modules~70414090-2fea-41a2-be5a-50b16c221214
omeraplak (Migrated from github.com) approved these changes 2020-10-05 02:16:58 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
mhrrmk
yildirayunlu
biskuvit
aliemir
necatiozmen
omeraplak
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
pankod/next-boilerplate!123
No description provided.