supermaven-inc/supermaven-nvim
1
0
Fork 0
Code Issues 56 Pull requests 13 Projects Releases Packages Wiki Activity Actions

feat(#49): exposing suggestion_group in config settings #51

Open
AlejandroSuero wants to merge 4 commits from AlejandroSuero/feature/exposing-suggestion-group into main
pull from: AlejandroSuero/feature/exposing-suggestion-group
merge into: supermaven-inc:main
Conversation 2 Commits 4 Files changed 3 +21 -6
AlejandroSuero commented 2024-06-06 19:22:04 -04:00 (Migrated from github.com)
Copy link

With this changes suggestion_group will be exposed to the config under config.color like:

require("supermaven-nvim").setup({
  color = {
    suggestion_group = "Comment",
  },
})

Allowing users to change it in an easier way.

https://github.com/supermaven-inc/supermaven-nvim/assets/71392160/1fc06cc3-79ce-49c3-84cd-50bb3ca49692

Closes #49.

With this changes `suggestion_group` will be exposed to the config under `config.color` like: ```lua require("supermaven-nvim").setup({ color = { suggestion_group = "Comment", }, }) ``` Allowing users to change it in an easier way. --- https://github.com/supermaven-inc/supermaven-nvim/assets/71392160/1fc06cc3-79ce-49c3-84cd-50bb3ca49692 Closes #49.
👍 1
AlejandroSuero commented 2024-06-06 20:20:07 -04:00 (Migrated from github.com)
Copy link

@sm-victorw @super-jacob When discussing the behaviour on #49 about how SupermavenSuggestion highlight group is set. I tested out using lazy.nvim changing it from lazy = false to event = "VeryLazy" and here are the results:

https://github.com/supermaven-inc/supermaven-nvim/assets/71392160/c4b1df43-2cdd-462c-a64d-b943aac4fa4a

Should I change this behaviour to create the group SupermavenSuggestion when loading the plugin in this PR, or create another PR with those changes?

EDIT:

Apparently @arnevm123 has created one PR solving this in #53.

@sm-victorw @super-jacob When discussing the behaviour on #49 about how `SupermavenSuggestion` highlight group is set. I tested out using [lazy.nvim](https://github.com/folke/lazy.nvim) changing it from `lazy = false` to `event = "VeryLazy"` and here are the results: https://github.com/supermaven-inc/supermaven-nvim/assets/71392160/c4b1df43-2cdd-462c-a64d-b943aac4fa4a Should I change this behaviour to create the group `SupermavenSuggestion` when loading the plugin in this PR, or create another PR with those changes? EDIT: Apparently @arnevm123 has created one PR solving this in #53.
AlejandroSuero commented 2024-06-06 20:31:02 -04:00 (Migrated from github.com)
Copy link

@sm-victorw @super-jacob the changes will be the following:

Delete setting SupermavenSuggestion group in document_listener.lua on VimEnter and left only on ColorSchem event.

And set SupermavenSuggestion group in init.lua in M.setup(args) function without creating an autocmd on events.

@sm-victorw @super-jacob the changes will be the following: Delete setting `SupermavenSuggestion` group in `document_listener.lua` on `VimEnter` and left only on `ColorSchem` event. And set `SupermavenSuggestion` group in `init.lua` in `M.setup(args)` function without creating an `autocmd` on events.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin AlejandroSuero/feature/exposing-suggestion-group:AlejandroSuero/feature/exposing-suggestion-group
git switch AlejandroSuero/feature/exposing-suggestion-group

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff AlejandroSuero/feature/exposing-suggestion-group
git switch AlejandroSuero/feature/exposing-suggestion-group
git rebase main
git switch main
git merge --ff-only AlejandroSuero/feature/exposing-suggestion-group
git switch AlejandroSuero/feature/exposing-suggestion-group
git rebase main
git switch main
git merge --no-ff AlejandroSuero/feature/exposing-suggestion-group
git switch main
git merge --squash AlejandroSuero/feature/exposing-suggestion-group
git switch main
git merge --ff-only AlejandroSuero/feature/exposing-suggestion-group
git switch main
git merge AlejandroSuero/feature/exposing-suggestion-group
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
supermaven-inc/supermaven-nvim!51
No description provided.