Siderus/Orion
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

Feature/105 add tray icon #101

Merged
kernelwhisperer merged 7 commits from feature/105-add-tray-icon into master 2018-05-10 03:30:47 -04:00
Conversation 8 Commits 7 Files changed 5 +45 -13
kernelwhisperer commented 2018-05-08 11:01:12 -04:00 (Migrated from github.com)
Copy link

What changed?

Added tray icon.
Now the app runs in the background when you close all windows, unless you quit from the tray icon.

## What changed? Added tray icon. Now the app runs in the background when you close all windows, unless you quit from the tray icon.
koalalorenzo (Migrated from github.com) requested changes 2018-05-08 13:50:06 -04:00
app/setup-tray-icon.js
@ -0,0 +1,35 @@
import path from 'path'
koalalorenzo (Migrated from github.com) commented 2018-05-08 13:39:45 -04:00
Copy link

Disable here the trayicon on macOS! There is no need for that as the app on that platform will not quit if all the windows are closed.

Disable here the trayicon on macOS! There is no need for that as the app on that platform will not quit if all the windows are closed.
koalalorenzo (Migrated from github.com) commented 2018-05-08 13:39:56 -04:00
Copy link

Docs? Maybe? :D

Docs? Maybe? :D
koalalorenzo commented 2018-05-08 13:52:05 -04:00 (Migrated from github.com)
Copy link

If I close the main window i can't see the trayicon on Ubuntu 16.04

screen shot 2018-05-08 at 19 49 54

on macOS (which should be disabled) I see a giant icon :D

screen shot 2018-05-08 at 19 37 59
If I close the main window i can't see the trayicon on Ubuntu 16.04 <img width="1440" alt="screen shot 2018-05-08 at 19 49 54" src="https://user-images.githubusercontent.com/33528/39773662-0ca95456-52f9-11e8-8e14-3b8d4eb5461e.png"> on macOS (which should be disabled) I see a giant icon :D <img width="107" alt="screen shot 2018-05-08 at 19 37 59" src="https://user-images.githubusercontent.com/33528/39773718-25484fd0-52f9-11e8-9381-75e8d6d484b8.png">
koalalorenzo (Migrated from github.com) requested changes 2018-05-08 14:08:00 -04:00
app/setup-tray-icon.js
@ -0,0 +1,35 @@
import path from 'path'
koalalorenzo (Migrated from github.com) commented 2018-05-08 13:53:57 -04:00
Copy link

Use NativeImage (https://electronjs.org/docs/api/native-image#nativeimagecreatefrompathpath)
This will ensure to have the best graphics and scaled image. AFAIK

Use NativeImage (https://electronjs.org/docs/api/native-image#nativeimagecreatefrompathpath) This will ensure to have the best graphics and scaled image. AFAIK
kernelwhisperer commented 2018-05-09 07:11:51 -04:00 (Migrated from github.com)
Copy link

Let me know if the latest commit solves this :)

Let me know if the latest commit solves this :)
koalalorenzo commented 2018-05-09 12:23:55 -04:00 (Migrated from github.com)
Copy link

It looks like it (I will test it this evening)

The Ubuntu one seems to be a Distro/Configuration-driven situation.

It looks like it (I will test it this evening) The Ubuntu one seems to be a Distro/Configuration-driven situation.
koalalorenzo commented 2018-05-09 14:47:03 -04:00 (Migrated from github.com)
Copy link

By installing it from the dpkg and then running it it works :)

By installing it from the dpkg and then running it it works :)
koalalorenzo commented 2018-05-10 02:19:45 -04:00 (Migrated from github.com)
Copy link

dpkg dependencies added to the docs so we know that when running from source the user should install the appindicator/missing pkgs! Ready to merge

dpkg dependencies added to the docs so we know that when running from source the user should install the appindicator/missing pkgs! Ready to merge
koalalorenzo (Migrated from github.com) approved these changes 2018-05-10 03:30:32 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
koalalorenzo
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!101
No description provided.