Siderus/Orion
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

Remove shared ipfs api instance to one per window #113

Merged
kernelwhisperer merged 1 commit from bugfix/125-download-multiple-files into master 2018-05-21 05:57:14 -04:00
Conversation 1 Commits 1 Files changed 5 +15 -28
kernelwhisperer commented 2018-05-21 04:20:42 -04:00 (Migrated from github.com)
Copy link

What changed?

Now each window has its own api connection, the client is no longer shared between them.
There is a significant performance drop which can be seen (the time after the loading wheel disappears until the data is loaded into the component).
What we can do is add a loading wheel to show the data is loading, but is this the solution we want?
Note that the bug https://dev.siderus.team/issues/125 is fixed by this change, we can now download QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn.

## What changed? Now each window has its own api connection, the client is no longer shared between them. There is a significant performance drop which can be seen (the time after the loading wheel disappears until the data is loaded into the component). What we can do is add a loading wheel to show the data is loading, but is this the solution we want? Note that the bug https://dev.siderus.team/issues/125 is fixed by this change, we can now download `QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn`.
koalalorenzo (Migrated from github.com) approved these changes 2018-05-21 04:34:43 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
koalalorenzo
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!113
No description provided.