Fix "run garbage collector" button #132

Merged

kernelwhisperer merged 2 commits from bugfix/161-cannot-set-peers-of-undefined into master 2018-06-08 10:05:40 -04:00

Conversation 2 Commits 2 Files changed 1 +16 -24

kernelwhisperer commented 2018-06-08 01:55:54 -04:00 (Migrated from github.com)

Copy link

What changed?

Fixed bug 161 and it's related sentry issues.

The problem was how we called the loadData function, if it's not wrapped under an arrow function, this is evaluated to undefined.

Also fixed the refreshing: because the button is by default of type submit it caused the form to be submitted and the window to be reloaded.

## What changed? Fixed bug 161 and it's related sentry issues. The problem was how we called the `loadData` function, if it's not wrapped under an arrow function, `this` is evaluated to `undefined`. Also fixed the refreshing: because the button is by default of type submit it caused the form to be submitted and the window to be reloaded.

koalalorenzo (Migrated from github.com) requested changes 2018-06-08 02:00:43 -04:00

app/windows/Settings/Components/RepositoryPanel.jsx

koalalorenzo (Migrated from github.com) commented 2018-06-08 02:00:35 -04:00

Copy link

Are you sure this line is correct? why not:

.then(this.props.informationStore.loadData)

Are you sure this line is correct? why not: ``` .then(this.props.informationStore.loadData) ```

koalalorenzo (Migrated from github.com) approved these changes 2018-06-08 02:09:43 -04:00

Sign in to join this conversation.

Reviewers

No reviewers

koalalorenzo

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Siderus/Orion!132

No description provided.