Allow to add directories #138
No reviewers
Labels
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Siderus/Orion!138
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "bugfix/156-allow-to-upload-directories-on-win"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What changed?
Added two new sub menus under
File: Add File and Add Directory.@ -6,4 +6,2 @@const { app, dialog, shell } = remote/*** Returns `true` if the user wants to wrap all files under a single dir,remoteisundefinedwhen is called from the main process (which is happening now since I used this in the menu), but importing{ app, dialog, shell }directly seems to work.@ -2,16 +2,41 @@* Import/require this file to set up the Menu of the windowsWhy this doesn't have app.mainWindow and the other has?
@ -2,16 +2,41 @@* Import/require this file to set up the Menu of the windowsThis is ran before the StorageList is created. Maybe is worth considering moving this to StorageList and creating the menu afterwards? We disable the menu for any other window anyway...
@ -2,16 +2,41 @@* Import/require this file to set up the Menu of the windowsI see, as we discussed maybe move the creation of the Menu into the Storage Window only.
@ -2,16 +2,41 @@* Import/require this file to set up the Menu of the windowsTurns out we can only create the menu from the main process. Nonetheless, I added the missing
app.mainWindowto the dialog and it seems to work (StorageList is unusable while the dialog is open).The warning I was getting: "Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged." seems to be unrelated to this.