Siderus/Orion
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

Feature/165 improve ux for alerts #139

Merged
kernelwhisperer merged 5 commits from feature/165-improve-ux-for-alerts into master 2018-06-19 01:25:15 -04:00
Conversation 6 Commits 5 Files changed 5 +118 -44
kernelwhisperer commented 2018-06-17 06:23:52 -04:00 (Migrated from github.com)
Copy link

What changed?

The confirmation dialog for removing files.

## What changed? The confirmation dialog for removing files.
koalalorenzo (Migrated from github.com) requested changes 2018-06-17 06:50:08 -04:00
app/windows/Storage/fileIntegration.js
koalalorenzo (Migrated from github.com) commented 2018-06-17 06:48:31 -04:00
Copy link

I find Cancel and Delete confusing a little.
What do you think about Cancel and Ok?

I find `Cancel` and `Delete` confusing a little. What do you think about `Cancel` and `Ok`?
koalalorenzo (Migrated from github.com) commented 2018-06-17 06:50:01 -04:00
Copy link

What about Once done, You can't restore the files instead of You can't undo this action. (as if it already happened?)
What do you say?

What about `Once done, You can't restore the files` instead of `You can't undo this action.` (as if it already happened?) What do you say?
koalalorenzo commented 2018-06-17 07:11:09 -04:00 (Migrated from github.com)
Copy link

Do we have other places/alerts where we show hashes?
What about the dialog when you add files?

Do we have other places/alerts where we show hashes? What about the dialog when you add files?
kernelwhisperer commented 2018-06-18 01:52:05 -04:00 (Migrated from github.com)
Copy link

Added to Publish to IPNS and after uploading multiple files as well.

It looks like these are the only places we show a hash in a dialog.

Added to `Publish to IPNS` and after uploading multiple files as well. It looks like these are the only places we show a hash in a dialog.
koalalorenzo (Migrated from github.com) requested changes 2018-06-18 02:03:22 -04:00
app/windows/Storage/Components/StorageElement.jsx
koalalorenzo (Migrated from github.com) commented 2018-06-18 02:01:12 -04:00
Copy link

I guess that the hash is enough in the IPNS case, but if we can get the file names it would be helping a lot to understand what they have published! (maybe remove the size).

Think what the use would find useful here.

I guess that the hash is enough in the IPNS case, but if we can get the file names it would be helping a lot to understand what they have published! (maybe remove the size). Think what the use would find useful here.
app/windows/Storage/fileIntegration.js
koalalorenzo (Migrated from github.com) commented 2018-06-18 02:02:17 -04:00
Copy link

Add file name next to the hash, short the hash to few chars as length

Add file name next to the hash, short the hash to few chars as length
app/windows/Storage/fileIntegration.js
koalalorenzo (Migrated from github.com) commented 2018-06-18 02:03:05 -04:00
Copy link

Same here: show the file names, and a short hash

Same here: show the file names, and a short hash
kernelwhisperer commented 2018-06-18 04:54:20 -04:00 (Migrated from github.com)
Copy link

Updated to show filenames - hash - size. Let me know what you think

Updated to show `filenames - hash - size`. Let me know what you think
koalalorenzo (Migrated from github.com) approved these changes 2018-06-18 12:28:44 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
koalalorenzo
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!139
No description provided.