Shows the activity window when adding a new file #142

2018-06-26T07:33:33-04:00

kernelwhisperer commented

2018-06-26 07:33:33 -04:00

(Migrated from github.com)

What changed?

Added the activities window.
This is a WIP, but please take a look before I continue in this direction.

## What changed? Added the activities window. This is a WIP, but please take a look before I continue in this direction.

kernelwhisperer commented

2018-06-29 10:13:47 -04:00

(Migrated from github.com)

ready for review :)

koalalorenzo (Migrated from github.com) requested changes

2018-06-30 10:01:39 -04:00

koalalorenzo (Migrated from github.com) left a comment

We have also some tests that are failing... 😮

app/api.js

					
				@ -106,8 +110,54 @@ export function addFilesFromFSPath (filePaths, _queryGateways = queryGateways) {

				  if (!IPFS_CLIENT) return Promise.reject(ERROR_IPFS_UNAVAILABLE)

can we add few lines of comments to describe why/what?

also here: comments

app/index.js

					
				@ -286,6 +292,48 @@ app.on('start-orion', () => {

				  startWelcome().then(startOrion)

Few comments here?

koalalorenzo (Migrated from github.com) approved these changes

2018-07-02 13:03:30 -04:00

koalalorenzo (Migrated from github.com) left a comment

Well done 👏

Sign in to join this conversation.

No reviewers

koalalorenzo

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Siderus/Orion!142

				`@ -106,8 +110,54 @@ export function addFilesFromFSPath (filePaths, _queryGateways = queryGateways) {`
				`if (!IPFS_CLIENT) return Promise.reject(ERROR_IPFS_UNAVAILABLE)`

				`@ -286,6 +292,48 @@ app.on('start-orion', () => {`
				`startWelcome().then(startOrion)`

Rows
Columns