Siderus/Orion
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

remove version + update menus #144

Merged
kernelwhisperer merged 1 commit from feature/168-hide-app-version-in-the-menu-bar into master 2018-06-30 11:36:31 -04:00
Conversation 4 Commits 1 Files changed 1 -4
kernelwhisperer commented 2018-06-27 08:57:58 -04:00 (Migrated from github.com)
Copy link

What changed?

removed the menu with version and updates.

Fixes: #135

## What changed? removed the menu with version and updates. Fixes: #135
🎉 1
koalalorenzo (Migrated from github.com) requested changes 2018-06-27 11:51:16 -04:00
app/menu.js
koalalorenzo (Migrated from github.com) commented 2018-06-27 11:51:13 -04:00
Copy link

I guess we could just remove this line instead of the whole block.
If we do remove the entire block we will not give the user the opportunity to manually check for updates.

I guess we could just remove this line instead of the whole block. If we do remove the entire block we will not give the user the opportunity to manually check for updates.
kernelwhisperer (Migrated from github.com) reviewed 2018-06-29 05:19:07 -04:00
app/menu.js
kernelwhisperer (Migrated from github.com) commented 2018-06-29 05:19:06 -04:00
Copy link

Those two menus don't work, tested with v0.6.0:
screen shot 2018-06-29 at 12 15 26 pm

I do get a popup in the beginning asking me to check github though.
If we want this behavior (manual check) we need to make it work with electron-updater

Those two menus don't work, tested with `v0.6.0`: ![screen shot 2018-06-29 at 12 15 26 pm](https://user-images.githubusercontent.com/26041347/42084413-33bc5514-7b96-11e8-96ed-7ad6dac5ea7b.png) I do get a popup in the beginning asking me to check github though. If we want this behavior (manual check) we need to make it work with `electron-updater`
koalalorenzo (Migrated from github.com) reviewed 2018-06-29 07:20:55 -04:00
app/menu.js
koalalorenzo (Migrated from github.com) commented 2018-06-29 07:20:55 -04:00
Copy link

ok, then just remove the version and we will deal with it later in another issue (if it will be an option). How does it sound?

ok, then just remove the version and we will deal with it later in another issue (if it will be an option). How does it sound?
koalalorenzo (Migrated from github.com) approved these changes 2018-06-30 08:11:24 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
koalalorenzo
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!144
No description provided.