Siderus/Orion
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

Make import from hash an activity #165

Merged
kernelwhisperer merged 5 commits from feature/make-import-from-hash-an-activity into master 2018-08-05 13:29:54 -04:00
Conversation 4 Commits 5 Files changed 9 +155 -36
kernelwhisperer commented 2018-08-04 04:02:43 -04:00 (Migrated from github.com)
Copy link

What changed?

Import from hash now closes and shows the progress in the activities window instead.

## What changed? Import from hash now closes and shows the progress in the activities window instead.
koalalorenzo (Migrated from github.com) requested changes 2018-08-04 04:32:22 -04:00
app/api.js
koalalorenzo (Migrated from github.com) commented 2018-08-04 04:14:40 -04:00
Copy link

Do we want to make the Type as a Variable?

Do we want to make the Type as a Variable?
kernelwhisperer (Migrated from github.com) reviewed 2018-08-05 02:53:29 -04:00
app/api.js
kernelwhisperer (Migrated from github.com) commented 2018-08-05 02:53:29 -04:00
Copy link

Something like this?

const activityTypes = {
  ADD: 'add',
  IMPORT_FROM_HASH: 'import-from-hash'
}
Something like this? ``` const activityTypes = { ADD: 'add', IMPORT_FROM_HASH: 'import-from-hash' } ```
koalalorenzo (Migrated from github.com) reviewed 2018-08-05 03:04:00 -04:00
app/api.js
koalalorenzo (Migrated from github.com) commented 2018-08-05 03:04:00 -04:00
Copy link

yes that looks good to me :) So we can test this easier later on

yes that looks good to me :) So we can test this easier later on
koalalorenzo (Migrated from github.com) approved these changes 2018-08-05 13:19:57 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
koalalorenzo
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!165
No description provided.