Siderus/Orion
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

Persist activities to a file #169

Merged
kernelwhisperer merged 5 commits from feature/persist-activities into master 2018-08-08 13:16:37 -04:00
Conversation 8 Commits 5 Files changed 5 +56 -36
kernelwhisperer commented 2018-08-08 06:37:43 -04:00 (Migrated from github.com)
Copy link

What changed?

Activities will now persist when orion will quit.

## What changed? Activities will now persist when orion will quit.
koalalorenzo (Migrated from github.com) requested changes 2018-08-08 06:45:17 -04:00
app/index.js
@ -35,6 +36,7 @@ import ActivitiesWindow from './windows/Activities/window'
app.mainWindow = null
koalalorenzo (Migrated from github.com) commented 2018-08-08 06:45:09 -04:00
Copy link

.json?

`.json`?
koalalorenzo (Migrated from github.com) requested changes 2018-08-08 07:21:55 -04:00
koalalorenzo (Migrated from github.com) left a comment
Copy link

If I have an "active" and not completed acitivy, it will be saved with the old percentage. What should we do about it? Should we ignore them and save only the complete activities? Should we resume them? Or should we mark them as "interrupted"?

If I have an "active" and not completed acitivy, it will be saved with the old percentage. What should we do about it? Should we ignore them and save only the complete activities? Should we resume them? Or should we mark them as "interrupted"?
koalalorenzo commented 2018-08-08 07:22:34 -04:00 (Migrated from github.com)
Copy link

To test the change request, just create a big file, then add it. Then close the app and re open it with the Activity List.

screen shot 2018-08-08 at 13 20 23

To test the change request, just create a big file, then add it. Then close the app and re open it with the Activity List. ![screen shot 2018-08-08 at 13 20 23](https://user-images.githubusercontent.com/33528/43834346-0bd1dece-9b0e-11e8-98cd-fc3889f1e4b5.png)
kernelwhisperer commented 2018-08-08 08:40:13 -04:00 (Migrated from github.com)
Copy link

Hmm, is it possible to resume them?

Hmm, is it possible to resume them?
koalalorenzo commented 2018-08-08 08:42:51 -04:00 (Migrated from github.com)
Copy link

I don't think so. :( For now at least.

We need a different UI/structure to report failures, allow retry etc etc etc
The fact is that those actions could fail when resuming them: if the file is not there anymore we need to take care of that.

What do you think?

I don't think so. :( For now at least. We need a different UI/structure to report failures, allow retry etc etc etc The fact is that those actions could fail when resuming them: if the file is not there anymore we need to take care of that. What do you think?
kernelwhisperer commented 2018-08-08 08:58:07 -04:00 (Migrated from github.com)
Copy link

Alright, let's mark them as "interrupted" then :)

Alright, let's mark them as "interrupted" then :)
👍 1
koalalorenzo commented 2018-08-08 12:47:12 -04:00 (Migrated from github.com)
Copy link

We have a bug, while I was just adding a big file to test it, it did not appear on the list of the activities. but when it was completed it was there.

https://sentry.io/siderus-opensource/orion/issues/635560601/?environment=development

We have a bug, while I was just adding a big file to test it, it did not appear on the list of the activities. but when it was completed it was there. https://sentry.io/siderus-opensource/orion/issues/635560601/?environment=development
koalalorenzo (Migrated from github.com) approved these changes 2018-08-08 13:14:04 -04:00
koalalorenzo (Migrated from github.com) left a comment
Copy link

LGTM, tested on MacOS manually

LGTM, tested on MacOS manually
Sign in to join this conversation.
Reviewers
No reviewers
koalalorenzo
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!169
No description provided.