Siderus/Orion
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

Add share option to properties and storagelist #180

Merged
kernelwhisperer merged 3 commits from feature/add-share-capability into master 2018-08-22 02:23:15 -04:00
Conversation 4 Commits 3 Files changed 4 +81 -20
kernelwhisperer commented 2018-08-21 04:31:45 -04:00 (Migrated from github.com)
Copy link

What changed?

Insert here the changes.

## What changed? Insert here the changes.
koalalorenzo (Migrated from github.com) requested changes 2018-08-21 05:48:55 -04:00
app/util/shareMenuTemplate.js
koalalorenzo (Migrated from github.com) commented 2018-08-21 05:47:13 -04:00
Copy link

Should we move this to app/lib/sharing (example) ?

Should we move this to `app/lib/sharing` (example) ?
app/windows/Storage/fileIntegration.js
koalalorenzo (Migrated from github.com) commented 2018-08-21 05:48:26 -04:00
Copy link

Should we move these functions into app/lib/sharing/?

Should we move these functions into `app/lib/sharing/`?
kernelwhisperer commented 2018-08-22 00:53:14 -04:00 (Migrated from github.com)
Copy link

What should go into the lib folder? It's shorthand for libraries, right?

What should go into the `lib` folder? It's shorthand for `libraries`, right?
koalalorenzo commented 2018-08-22 01:09:51 -04:00 (Migrated from github.com)
Copy link

Yes! (tests are failing) 😮

Yes! (tests are failing) 😮
koalalorenzo (Migrated from github.com) approved these changes 2018-08-22 02:23:09 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
koalalorenzo
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!180
No description provided.