Siderus/Orion
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

114 Ensures that the configuration is correct (ensureDaemonConfigured) #94

Merged
koalalorenzo merged 7 commits from bug/114-ensureDaemonConfigured-api-not-running into master 2018-05-03 10:27:15 -04:00
Conversation 2 Commits 7 Files changed 3 +63 -20
koalalorenzo commented 2018-04-30 14:23:50 -04:00 (Migrated from github.com)
Copy link

What changed?

  • Moves from plain binary to json manipulation for ensureDaemonConfigured
  • Adds more UI feedback to what is happening under the hood.

Manual testing on macOS and Ubuntu 16.04 on multiple cases (init no repo, with another daemon running, with no extra daemon running)

## What changed? * Moves from plain binary to json manipulation for `ensureDaemonConfigured` * Adds more UI feedback to what is happening under the hood. Manual testing on macOS and Ubuntu 16.04 on multiple cases (init no repo, with another daemon running, with no extra daemon running)
kernelwhisperer (Migrated from github.com) approved these changes 2018-05-03 09:05:42 -04:00
app/daemon.js
kernelwhisperer (Migrated from github.com) commented 2018-05-03 09:04:42 -04:00
Copy link

Do we need to pass --api=${global.IPFS_MULTIADDR_API} here? What about the other addresses?

Do we need to pass `--api=${global.IPFS_MULTIADDR_API}` here? What about the other addresses?
koalalorenzo (Migrated from github.com) reviewed 2018-05-03 10:26:46 -04:00
app/daemon.js
koalalorenzo (Migrated from github.com) commented 2018-05-03 10:26:46 -04:00
Copy link

Yes, it is better to!
The others are configured on another method. AFAIK this is not documented and I was not able to find the other args

Yes, it is better to! The others are configured on another method. AFAIK this is not documented and I was not able to find the other args
Sign in to join this conversation.
Reviewers
No reviewers
kernelwhisperer
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Siderus/Orion!94
No description provided.