TwiN/go-away
1
0
Fork 0
Code Issues 8 Pull requests 2 Projects Releases 38 Packages Wiki Activity Actions

Add correct spelling of scunthorpe, closes #13 #14

Merged
psidex merged 3 commits from patch-1 into master 2021-07-02 13:17:56 -04:00
Conversation 5 Commits 3 Files changed 2 +2 -2
psidex commented 2021-07-01 20:32:49 -04:00 (Migrated from github.com)
Copy link
No description provided.
TwiN (Migrated from github.com) requested changes 2021-07-01 21:17:32 -04:00
falsepositives.go
@ -46,7 +46,7 @@ var falsePositives = []string{
"pushit",
"sassy",
TwiN (Migrated from github.com) commented 2021-07-01 21:17:28 -04:00
Copy link
	"scunthorpe",

Great catch!
Might as well remove the wrong spelling while we're at it.

I believe there's a test in goaway_test.go that may need to be updated as well to reflect that.

```suggestion "scunthorpe", ``` Great catch! Might as well remove the wrong spelling while we're at it. I believe there's a test in `goaway_test.go` that may need to be updated as well to reflect that.
psidex commented 2021-07-02 08:19:31 -04:00 (Migrated from github.com)
Copy link

I think that's it?

I think that's it?
codecov-commenter commented 2021-07-02 13:02:05 -04:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #14 (618c2bd) into master (f15ee8a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           53        53           
=========================================
  Hits            53        53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f15ee8a...618c2bd. Read the comment docs.

# [Codecov](https://codecov.io/gh/TwinProduction/go-away/pull/14?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.) Report > Merging [#14](https://codecov.io/gh/TwinProduction/go-away/pull/14?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.) (618c2bd) into [master](https://codecov.io/gh/TwinProduction/go-away/commit/f15ee8a8c0a5c8673e17c2a46db6baad4f7806aa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.) (f15ee8a) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/TwinProduction/go-away/pull/14/graphs/tree.svg?width=650&height=150&src=pr&token=25T9OQT9TM&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.)](https://codecov.io/gh/TwinProduction/go-away/pull/14?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.) ```diff @@ Coverage Diff @@ ## master #14 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 53 53 ========================================= Hits 53 53 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/TwinProduction/go-away/pull/14?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/TwinProduction/go-away/pull/14?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.). Last update [f15ee8a...618c2bd](https://codecov.io/gh/TwinProduction/go-away/pull/14?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.).
TwiN commented 2021-07-02 13:17:52 -04:00 (Migrated from github.com)
Copy link

Great work @psidex, thank you for your contribution!

Great work @psidex, thank you for your contribution!
❤️ 1
TwiN commented 2021-07-02 13:20:46 -04:00 (Migrated from github.com)
Copy link

Released in v1.1.4

Released in [v1.1.4](https://github.com/TwinProduction/go-away/releases/tag/v1.1.4)
Sign in to join this conversation.
Reviewers
No reviewers
TwiN
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
TwiN/go-away!14
No description provided.