TwiN/go-away
1
0
Fork 0
Code Issues 8 Pull requests 2 Projects Releases 38 Packages Wiki Activity Actions

Add scrap to false positives #37

Merged
tbantle22 merged 1 commit from patch-3 into master 2022-08-10 20:57:19 -04:00
Conversation 4 Commits 1 Files changed 1 +1
tbantle22 commented 2022-08-10 12:48:20 -04:00 (Migrated from github.com)
Copy link

Summary

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Added the documentation in README.md, if applicable.
<!-- Thank you for contributing! --> ## Summary <!-- If there's a relevant issue, you can just write the issue number below (e.g. #123) --> ## Checklist <!-- Replace [ ] by [X] if you have completed the item --> - [ ] Tested and/or added tests to validate that the changes work as intended, if applicable. - [ ] Added the documentation in `README.md`, if applicable.
codecov-commenter commented 2022-08-10 20:56:12 -04:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #37 (a0bf8d6) into master (d92629b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   99.47%   99.47%           
=======================================
  Files           1        1           
  Lines         191      191           
=======================================
  Hits          190      190           
  Misses          1        1

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

# [Codecov](https://codecov.io/gh/TwiN/go-away/pull/37?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.) Report > Merging [#37](https://codecov.io/gh/TwiN/go-away/pull/37?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.) (a0bf8d6) into [master](https://codecov.io/gh/TwiN/go-away/commit/d92629b2e73bb8b8c84069c8c9e619943f8f1c0a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.) (d92629b) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #37 +/- ## ======================================= Coverage 99.47% 99.47% ======================================= Files 1 1 Lines 191 191 ======================================= Hits 190 190 Misses 1 1 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Chris+C.)
TwiN commented 2022-08-10 20:56:58 -04:00 (Migrated from github.com)
Copy link

I guess this is most likely going to cause issues with sentences like "this is crap", which would be sanitized as "thisiscrap", but IMHO, "crap" isn't much of a profanity to begin with, so I'm fine with this type of false positive.

Worst case scenario, we'll have to add a few false negatives in the future.

I guess this is most likely going to cause issues with sentences like "this is crap", which would be sanitized as "thisi**scrap**", but IMHO, "crap" isn't much of a profanity to begin with, so I'm _fine_ with this type of false positive. Worst case scenario, we'll have to add a few false negatives in the future.
TwiN commented 2022-08-10 20:57:42 -04:00 (Migrated from github.com)
Copy link

Thank you for the contribution!

Thank you for the contribution!
TwiN commented 2022-08-10 20:59:22 -04:00 (Migrated from github.com)
Copy link

Released in v1.6.8

Released in [v1.6.8](https://github.com/TwiN/go-away/releases/tag/v1.6.8)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
TwiN/go-away!37
No description provided.