archcraft-os/archcraft-skeleton
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

rofi: better mouse support #1

Closed
antoine-hnkx wants to merge 1 commit from rofi-better-mouse-support into main
pull from: rofi-better-mouse-support
merge into: archcraft-os:main
Conversation 2 Commits 1 Files changed 1 +4
antoine-hnkx commented 2022-10-06 15:58:01 -04:00 (Migrated from github.com)
Copy link

Issue

Currently there is no entry selection on mouse hovering inside rofi menus and you have to use a double left click to confirm a selection instead of a single left click. (A single click is a better user experience in my opinion for using menus, especially on trackpads)

Solution

New config entry wich improve rofi menu navigation and selection with mouse pointers.
It adds:

  • Select entry when hovering with mouse
  • Accept entry on single left click release
  • Accept custom on control + single left click release

This also fixes another issue for which I had previously proposed another fix but found that if you accept the entries on the release of the click/double click (with the ! character) it prevents any accidental closing of the next rofi menu.

Overall I think this is a better solution and it works with all menus where as the other fix was only for the powermenu.
(I will be closing the previous fix after submitting this PR)

# Issue Currently there is no entry selection on mouse hovering inside rofi menus and you have to use a double left click to confirm a selection instead of a single left click. (A single click is a better user experience in my opinion for using menus, especially on trackpads) # Solution New config entry wich improve rofi menu navigation and selection with mouse pointers. It adds: - Select entry when hovering with mouse - Accept entry on single left click release - Accept custom on control + single left click release This also fixes another issue for which I had previously proposed [another fix](https://github.com/archcraft-os/archcraft-openbox/pull/7) but found that if you accept the entries on the release of the click/double click (with the `!` character) it prevents any accidental closing of the next rofi menu. Overall I think this is a better solution and it works with all menus where as the other fix was only for the powermenu. (I will be closing [the previous fix](https://github.com/archcraft-os/archcraft-openbox/pull/7) after submitting this PR)
antoine-hnkx commented 2022-12-29 06:18:56 -05:00 (Migrated from github.com)
Copy link

Hello @adi1090x, any feedback on why this was closed ?

Hello @adi1090x, any feedback on why this was closed ?
adi1090x commented 2022-12-29 06:20:55 -05:00 (Migrated from github.com)
Copy link

The file is deleted on newer version.

Also, it's a individual config choice.

Thank you for the PR though.

The file is deleted on newer version. Also, it's a individual config choice. Thank you for the PR though.
👍 1

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
archcraft-os/archcraft-skeleton!1
No description provided.