bigcode-project/starcoder
1
0
Fork 0
Code Issues 93 Pull requests 8 Projects Releases Packages Wiki Activity Actions

Update finetune launch command and remove local_rank #78

Open
nopperl wants to merge 2 commits from nopperl/fix-local-rank into main
pull from: nopperl/fix-local-rank
merge into: bigcode-project:main
Conversation 0 Commits 2 Files changed 2 +2 -3
nopperl commented 2023-06-20 09:40:41 -04:00 (Migrated from github.com)
Copy link

The readme instructs to use the old torch.distributed.launch command instead of torch.distributed.run, which is incompatible with finetune/finetune.py because it sets the local rank using --local-rank instead of --local_rank, leading to the following error:

finetune.py: error: unrecognized arguments: --local-rank=0

This PR updates the readme to use torch.distributed.run.

Also, it seems like the --local_rank argument is not necessary because it's not used in finetune/finetune.py at all, so I removed it.

The readme instructs to use the old `torch.distributed.launch` command instead of `torch.distributed.run`, which is incompatible with `finetune/finetune.py` because it sets the local rank using `--local-rank` instead of `--local_rank`, leading to the following error: ``` finetune.py: error: unrecognized arguments: --local-rank=0 ``` This PR updates the readme to use `torch.distributed.run`. Also, it seems like the `--local_rank` argument is not necessary because it's not used in `finetune/finetune.py` at all, so I removed it.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin nopperl/fix-local-rank:nopperl/fix-local-rank
git switch nopperl/fix-local-rank

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff nopperl/fix-local-rank
git switch nopperl/fix-local-rank
git rebase main
git switch main
git merge --ff-only nopperl/fix-local-rank
git switch nopperl/fix-local-rank
git rebase main
git switch main
git merge --no-ff nopperl/fix-local-rank
git switch main
git merge --squash nopperl/fix-local-rank
git switch main
git merge --ff-only nopperl/fix-local-rank
git switch main
git merge nopperl/fix-local-rank
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
bigcode-project/starcoder!78
No description provided.