bscott/subtrackr
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases 15 Packages Wiki Activity Actions

Respect user currency preference in renewal reminder emails #60

Closed
Copilot wants to merge 3 commits from copilot/sub-pr-58-again into v0.4.8
pull from: copilot/sub-pr-58-again
merge into: bscott:v0.4.8
Conversation 2 Commits 3 Files changed 3 +5 -6
Copilot commented 2025-11-15 18:53:36 -05:00 (Migrated from github.com)
Copy link

Renewal reminder emails hardcoded the $ currency symbol instead of using the configured currency preference from SettingsService.

Changes

  • internal/service/email.go: Added CurrencySymbol field to ReminderData struct and populated it from settingsService.GetCurrencySymbol()
  • Updated email template to use {{.CurrencySymbol}} instead of hardcoded $

This aligns email behavior with the rest of the application which already respects currency settings.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Renewal reminder emails hardcoded the `$` currency symbol instead of using the configured currency preference from `SettingsService`. ## Changes - **`internal/service/email.go`**: Added `CurrencySymbol` field to `ReminderData` struct and populated it from `settingsService.GetCurrencySymbol()` - Updated email template to use `{{.CurrencySymbol}}` instead of hardcoded `$` This aligns email behavior with the rest of the application which already respects currency settings. <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/bscott/subtrackr/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.
Copilot commented 2025-11-15 19:00:21 -05:00 (Migrated from github.com)
Copy link

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • smtp.example.com
    • Triggering command: /tmp/go-build679976730/b001/service.test -test.testlogfile=/tmp/go-build679976730/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `smtp.example.com` > - Triggering command: `/tmp/go-build679976730/b001/service.test -test.testlogfile=/tmp/go-build679976730/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true` (dns block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/bscott/subtrackr/settings/copilot/coding_agent) (admins only) > > </details>
copilot-pull-request-reviewer[bot] (Migrated from github.com) reviewed 2025-11-15 19:05:22 -05:00
copilot-pull-request-reviewer[bot] (Migrated from github.com) left a comment
Copy link

Pull Request Overview

This PR updates renewal reminder emails to respect the user's configured currency preference instead of hardcoding the $ symbol.

  • Added CurrencySymbol field to the ReminderData struct and populated it from settingsService.GetCurrencySymbol()
  • Updated the renewal reminder email template to use the dynamic currency symbol
  • Moved github.com/dromara/carbon/v2 from indirect to direct dependency in go.mod

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
internal/service/email.go Added currency symbol support to renewal reminder emails by including CurrencySymbol field in template data
go.mod Moved carbon package from indirect to direct dependency
go.sum Removed unused indirect dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

## Pull Request Overview This PR updates renewal reminder emails to respect the user's configured currency preference instead of hardcoding the `$` symbol. - Added `CurrencySymbol` field to the `ReminderData` struct and populated it from `settingsService.GetCurrencySymbol()` - Updated the renewal reminder email template to use the dynamic currency symbol - Moved `github.com/dromara/carbon/v2` from indirect to direct dependency in `go.mod` ### Reviewed Changes Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments. | File | Description | | ---- | ----------- | | internal/service/email.go | Added currency symbol support to renewal reminder emails by including `CurrencySymbol` field in template data | | go.mod | Moved carbon package from indirect to direct dependency | | go.sum | Removed unused indirect dependencies | --- 💡 <a href="/bscott/subtrackr/new/main/.github/instructions?filename=*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
bscott/subtrackr!60
No description provided.