cathayddt/bdk
1
0
Fork 0
Code Issues 14 Pull requests Projects Releases 20 Packages Wiki Activity Actions

Update: 3.1.0 besu network #113

Merged
Yorkchung merged 3 commits from 3.1.0 into master 2024-12-26 01:18:54 -05:00
Conversation 7 Commits 3 Files changed 118 +2146 -1523
Yorkchung commented 2024-12-25 00:46:11 -05:00 (Migrated from github.com)
Copy link

PULL REQUEST

Before

說明 (Description)

  • Add Besu network command support.
  • Add network type support to replace Quorum-specific logic.

相關問題 (Linked Issues)

貢獻種類 (Type of change)

  • Bug fix (除錯 non-breaking change which fixes an issue)
  • New feature (增加新功能 non-breaking change which adds functionality)
  • Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected)
  • Doc change (需要更新文件 this change requires a documentation update)

測試環境 (Test Configuration):

  • OS: 14.2.1
  • NodeJS Version: 18.18.2
  • NPM Version: 10.5.0
  • Docker Version: 24.0.6

檢查清單 (Checklist):

  • 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project)
  • 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code)
  • 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas)
  • 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation)
  • 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings)
  • 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works)
  • 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings)

我已完成以上清單，並且同意遵守 Code of Conduct

I have completed the checklist and agree to abide by the code of conduct.

  • 同意 (I consent)
# PULL REQUEST ## Before <!-- Please check the one that applies to this PR using "x". --> - [x] 遵守 Commit 規範 (follow [commit convention](https://github.com/cathayddt/bdk/blob/master/.github/COMMIT_CONVENTION.md)) - [x] 遵守 Contributing 規範 (follow [contributing](https://github.com/cathayddt/bdk/blob/master/.github/CONTRIBUTING.md)) ## 說明 (Description) <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> <!--請簡單說明此PR的更動、被修復的問題以及相關的原因，並請列出這個更動所需要的任何相依模組/套件。 Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.--> - Add Besu network command support. - Add network type support to replace Quorum-specific logic. ## 相關問題 (Linked Issues) <!-- - Related issues linked `fixes #number` - Tests added. Pass Coverage. - Errors have a helpful link. --> ## 貢獻種類 (Type of change) - [x] Bug fix (除錯 non-breaking change which fixes an issue) - [x] New feature (增加新功能 non-breaking change which adds functionality) - [x] Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected) - [x] Doc change (需要更新文件 this change requires a documentation update) **測試環境 (Test Configuration)**: * OS: 14.2.1 * NodeJS Version: 18.18.2 * NPM Version: 10.5.0 * Docker Version: 24.0.6 ## 檢查清單 (Checklist): - [x] 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project) - [x] 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code) - [x] 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas) - [x] 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation) - [x] 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings) - [x] 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works) - [x] 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings) 我已完成以上清單，並且同意遵守 [Code of Conduct](CODE_OF_CONDUCT.md) I have completed the checklist and agree to abide by the [code of conduct](CODE_OF_CONDUCT.md). - [x] 同意 (I consent)
kth-tw (Migrated from github.com) reviewed 2024-12-25 00:46:11 -05:00
kidneyweakx (Migrated from github.com) reviewed 2024-12-25 22:43:39 -05:00
.github/workflows/integration-test.yml
kidneyweakx (Migrated from github.com) commented 2024-12-25 22:43:39 -05:00
Copy link

delete the comment in workflows' yaml

delete the comment in workflows' yaml
Yorkchung (Migrated from github.com) reviewed 2024-12-25 22:46:37 -05:00
.github/workflows/integration-test.yml
Yorkchung (Migrated from github.com) commented 2024-12-25 22:46:37 -05:00
Copy link

deleted

deleted
johnny30678 (Migrated from github.com) reviewed 2024-12-26 00:33:13 -05:00
.github/workflows/integration-test.yml
johnny30678 (Migrated from github.com) commented 2024-12-25 21:06:02 -05:00
Copy link

這個註解有需要留嗎？

這個註解有需要留嗎？
kidneyweakx (Migrated from github.com) reviewed 2024-12-26 00:53:30 -05:00
package.json
@ -18,7 +18,8 @@
"kth-tw (https://github.com/kth-tw)",
kidneyweakx (Migrated from github.com) commented 2024-12-26 00:53:30 -05:00
Copy link

) in "

) in "
Yorkchung (Migrated from github.com) reviewed 2024-12-26 00:56:14 -05:00
package.json
@ -18,7 +18,8 @@
"kth-tw (https://github.com/kth-tw)",
Yorkchung (Migrated from github.com) commented 2024-12-26 00:56:14 -05:00
Copy link

fixed

fixed
johnny30678 (Migrated from github.com) approved these changes 2024-12-26 01:10:14 -05:00
Sign in to join this conversation.
Reviewers
No reviewers
kth-tw
johnny30678
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cathayddt/bdk!113
No description provided.