orderer/peer up & down need hostname.toLowerCase() #25 #27

2021-12-09T20:45:28-05:00

SecondDim commented

2021-12-09 20:45:28 -05:00

(Migrated from github.com)

PULL REQUEST

說明 (Description)

原本修改讓使用者輸入 hostname 為小寫，後來修改為全部依照使用者輸入為主

貢獻種類 (Type of change)

Bug fix (除錯 non-breaking change which fixes an issue)
New feature (增加新功能 non-breaking change which adds functionality)
Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected)
Doc change (需要更新文件 this change requires a documentation update)

測試環境 (Test Configuration):

OS:
NodeJS Version:
NPM Version:
Docker Version:

檢查清單 (Checklist):

我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project)
我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code)
我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas)
我有在文件中進行必要的更動 (I have made corresponding changes to the documentation)
我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings)
我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works)
我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings)

我已完成以上清單，並且同意遵守 Code of Conduct

I have completed the checklist and agree to abide by the code of conduct.

同意 (I consent)

# PULL REQUEST ## 說明 (Description) 原本修改讓使用者輸入 hostname 為小寫，後來修改為全部依照使用者輸入為主 ## 相關問題 (Linked Issues) #25 建立 docker-compose.yaml 強制轉小寫，但是 up/down 時沒有轉換。修改為建立時不強制轉小寫 ## 貢獻種類 (Type of change) - [x] Bug fix (除錯 non-breaking change which fixes an issue) - [ ] New feature (增加新功能 non-breaking change which adds functionality) - [ ] Breaking change (可能導致相容性問題 fix or feature that would cause existing functionality to not work as expected) - [ ] Doc change (需要更新文件 this change requires a documentation update) **測試環境 (Test Configuration)**: * OS: * NodeJS Version: * NPM Version: * Docker Version: ## 檢查清單 (Checklist): - [x] 我的程式碼遵從此專案的規範 (My code follows the style guidelines of this project) - [x] 我有對於自己的程式碼進行測試檢查 (I have performed a self-review of my own code) - [x] 我有在程式碼中提供必要的註解 (I have commented my code, particularly in hard-to-understand areas) - [ ] 我有在文件中進行必要的更動 (I have made corresponding changes to the documentation) - [x] 我的程式碼更動沒有顯著增加錯誤數量 (My changes generate no new warnings) - [ ] 我有新增必要的單元測試 (I have added tests that prove my fix is effective or that my feature works) - [x] 我有檢查並更正程式碼錯誤的拼字 (I have checked my code and corrected any misspellings) 我已完成以上清單，並且同意遵守 [Code of Conduct](CODE_OF_CONDUCT.md) I have completed the checklist and agree to abide by the [code of conduct](CODE_OF_CONDUCT.md). - [x] 同意 (I consent)

RuiSiang (Migrated from github.com) reviewed

2021-12-09 20:45:28 -05:00

kth-tw (Migrated from github.com) reviewed

2021-12-12 21:58:24 -05:00

src/service/peer.ts

					
				@ -189,7 +189,7 @@ export default class Peer extends AbstractService {

				  }

第一步是204行吧

SecondDim (Migrated from github.com) reviewed

2021-12-13 02:13:14 -05:00

src/service/peer.ts

					
				@ -189,7 +189,7 @@ export default class Peer extends AbstractService {

				  }

這不是我寫的，我只有刪掉未知符號，這應該是前幾個 commit 有人新增的

kth-tw (Migrated from github.com) approved these changes

2021-12-13 20:01:29 -05:00

Sign in to join this conversation.

No reviewers

RuiSiang

kth-tw

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cathayddt/bdk!27

				`@ -189,7 +189,7 @@ export default class Peer extends AbstractService {`
				`}`

Rows
Columns