katniny/Auride
1
0
Fork 0
Code Issues 11 Pull requests Projects Releases 2 Packages Wiki Activity Actions

Move note deletion to the server #118

Merged
katniny merged 2 commits from move-deleting-notes-to-server into main 2025-11-16 05:39:17 -05:00
Conversation 1 Commits 2 Files changed 13 +576 -16
katniny commented 2025-11-16 05:26:04 -05:00 (Migrated from github.com)
Copy link

Description of Changes

This PR moves the note deletion logic to the server-side, and makes the following improvements:

  • Utilizing nodemon on the backend, which will detect changes and restart the server rather than having to do it manually per change
  • Fixes bug that made it so you couldn't delete notes
  • The parent note of a reply will now have its reply count updated when a reply is deleted
  • Improvements to the note deletion UI
  • The note div on the page will now be deleted when a user initializes deletion (old behavior was that the page just refreshed)

Visual Sample

https://github.com/user-attachments/assets/81667dfb-d282-4c76-a2d4-2a9984fed986

Checklist

  • I have thoroughly tested my changes to the best of my ability
    • You agree that you have tested your changes, and that you are not opening a Pull Request that you're unsure if it works.
  • I confirm I have not contributed anything that would impact Auride's licensing and/or usage
    • Auride is a commercial product that Katniny Studios can profit from. Please do not add copyrighted material to your Pull Request, however there are exceptions (e.g. our Spotify integration).
  • This Pull Request fixes a critical issue that should be reviewed and merged as soon as possible
    • This includes things such as security vulnerabilities, ways to manipulate data, etc.
  • I've read the latest CONTRIBUTING.md (last updated: September 15, 2025) and will follow the guidelines
    • Please make sure to read it, we use this as the standard when reviewing contributions, so it's in your best interest to be familiar with it!
  • I updated the version and added the update log
### Description of Changes --- This PR moves the note deletion logic to the server-side, and makes the following improvements: - Utilizing nodemon on the backend, which will detect changes and restart the server rather than having to do it manually per change - Fixes bug that made it so you couldn't delete notes - The parent note of a reply will now have its reply count updated when a reply is deleted - Improvements to the note deletion UI - The note div on the page will now be deleted when a user initializes deletion (old behavior was that the page just refreshed) ### Visual Sample --- https://github.com/user-attachments/assets/81667dfb-d282-4c76-a2d4-2a9984fed986 ### Checklist --- - [x] I have thoroughly tested my changes to the best of my ability - You agree that you have tested your changes, and that you are not opening a Pull Request that you're unsure if it works. - [x] I confirm I have not contributed anything that would impact Auride's licensing and/or usage - Auride is a **commercial** product that Katniny Studios can profit from. Please do not add copyrighted material to your Pull Request, however there are exceptions (e.g. our Spotify integration). - [ ] This Pull Request fixes a **critical** issue that should be reviewed and merged as soon as possible - This includes things such as security vulnerabilities, ways to manipulate data, etc. - [x] I've read the latest [CONTRIBUTING.md](https://github.com/katniny/auride/blob/main/CONTRIBUTING.md) (last updated: September 15, 2025) and will follow the guidelines - Please make sure to read it, we use this as the standard when reviewing contributions, so it's in your best interest to be familiar with it! - [x] I updated the version and added the update log - Unsure what this means? Please read [CONTRIBUTING.md](https://github.com/katniny/auride/blob/main/CONTRIBUTING.md).
katniny (Migrated from github.com) reviewed 2025-11-16 05:31:16 -05:00
src/public/assets/js/ui/deleteNotePopup.js
@ -32,16 +33,103 @@ function closeDeleteNoteUI() {
}
katniny (Migrated from github.com) commented 2025-11-16 05:31:16 -05:00
Copy link

uncomment this, forgot to :3

uncomment this, forgot to :3
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
katniny/Auride!118
No description provided.