katniny/Auride
1
0
Fork 0
Code Issues 11 Pull requests Projects Releases 2 Packages Wiki Activity Actions

Seperate greeting code #125

Merged
katniny merged 1 commit from seperate-greeting-text into main 2025-12-01 01:04:47 -05:00
Conversation 4 Commits 1 Files changed 5 +35 -36
katniny commented 2025-12-01 01:03:15 -05:00 (Migrated from github.com)
Copy link

Description of Changes

Adds more greetings & moves the greeting code away from ts_fas_acih.js, as well as cleans up the code quite a bit.

Visual Sample

Have a good night at midnight:
image

Good early morning at 5am:
image

Good morning at 9am:
image

Good afternoon at 1pm:
image

Good evening at 6pm:
image

Good late night at 10pm:
image

(Works in an authenticated state as well.)

Checklist

  • I have thoroughly tested my changes to the best of my ability
    • You agree that you have tested your changes, and that you are not opening a Pull Request that you're unsure if it works.
  • I confirm I have not contributed anything that would impact Auride's licensing and/or usage
    • Auride is a commercial product that Katniny Studios can profit from. Please do not add copyrighted material to your Pull Request, however there are exceptions (e.g. our Spotify integration).
  • This Pull Request fixes a critical issue that should be reviewed and merged as soon as possible
    • This includes things such as security vulnerabilities, ways to manipulate data, etc.
  • I've read the latest CONTRIBUTING.md (last updated: September 15, 2025) and will follow the guidelines
    • Please make sure to read it, we use this as the standard when reviewing contributions, so it's in your best interest to be familiar with it!
  • I updated the version and added the update log
### Description of Changes --- Adds more greetings & moves the greeting code away from `ts_fas_acih.js`, as well as cleans up the code quite a bit. ### Visual Sample --- Have a good night at midnight: <img width="648" height="133" alt="image" src="https://github.com/user-attachments/assets/5bb89993-76ab-463d-964d-dccaa921464c" /> Good early morning at 5am: <img width="561" height="117" alt="image" src="https://github.com/user-attachments/assets/f423b6f1-192c-4bdb-ab5b-c0ba47dbbb6d" /> Good morning at 9am: <img width="646" height="108" alt="image" src="https://github.com/user-attachments/assets/ce46d1e7-2e95-4cf7-87ed-6c53f359ac66" /> Good afternoon at 1pm: <img width="606" height="113" alt="image" src="https://github.com/user-attachments/assets/ba70ff7c-44ad-4ac5-9c1c-94868896333e" /> Good evening at 6pm: <img width="573" height="110" alt="image" src="https://github.com/user-attachments/assets/33290105-eac7-4e5a-819b-d69dc8d24926" /> Good late night at 10pm: <img width="578" height="116" alt="image" src="https://github.com/user-attachments/assets/70ae1019-2f0b-4ca4-87e0-41ec4dd51182" /> (Works in an authenticated state as well.) ### Checklist --- - [x] I have thoroughly tested my changes to the best of my ability - You agree that you have tested your changes, and that you are not opening a Pull Request that you're unsure if it works. - [x] I confirm I have not contributed anything that would impact Auride's licensing and/or usage - Auride is a **commercial** product that Katniny Studios can profit from. Please do not add copyrighted material to your Pull Request, however there are exceptions (e.g. our Spotify integration). - [ ] This Pull Request fixes a **critical** issue that should be reviewed and merged as soon as possible - This includes things such as security vulnerabilities, ways to manipulate data, etc. - [x] I've read the latest [CONTRIBUTING.md](https://github.com/katniny/auride/blob/main/CONTRIBUTING.md) (last updated: September 15, 2025) and will follow the guidelines - Please make sure to read it, we use this as the standard when reviewing contributions, so it's in your best interest to be familiar with it! - [x] I updated the version and added the update log - Unsure what this means? Please read [CONTRIBUTING.md](https://github.com/katniny/auride/blob/main/CONTRIBUTING.md).
miku4k (Migrated from github.com) reviewed 2025-12-01 02:51:28 -05:00
src/updates.html
@ -68,0 +69,4 @@
<h2>v2025.11.30_alpha</h2>
<h3 style="color: var(--text-semi-transparent);">Released: November 30, 2025</h3>
<li>Added more greetings</li>
<li>(Dev Env) Separated greeting code & </li>
miku4k (Migrated from github.com) commented 2025-12-01 02:51:27 -05:00
Copy link
                                <li>(Dev Env) Separated greeting code</li>
```suggestion <li>(Dev Env) Separated greeting code</li> ```
miku4k (Migrated from github.com) reviewed 2025-12-01 02:51:40 -05:00
src/public/assets/js/ui/greeting.js
@ -0,0 +5,4 @@
h >= 12 && h < 17 ? "Good afternoon" :
h >= 17 && h < 20 ? "Good evening" :
h >= 21 && h < 24 ? "Good late night" :
"Have a good night";
miku4k (Migrated from github.com) commented 2025-12-01 02:51:40 -05:00
Copy link

Kinda completely arbitrary?

Me personally, wouldn't put the hours like that. Also when is noon?

Kinda completely arbitrary? Me personally, wouldn't put the hours like that. Also when is noon?
katniny (Migrated from github.com) reviewed 2025-12-01 04:22:49 -05:00
src/public/assets/js/ui/greeting.js
@ -0,0 +5,4 @@
h >= 12 && h < 17 ? "Good afternoon" :
h >= 17 && h < 20 ? "Good evening" :
h >= 21 && h < 24 ? "Good late night" :
"Have a good night";
katniny (Migrated from github.com) commented 2025-12-01 04:22:49 -05:00
Copy link

noon falls under "afternoon"

noon falls under "afternoon"
miku4k (Migrated from github.com) reviewed 2025-12-01 05:16:24 -05:00
src/public/assets/js/ui/greeting.js
@ -0,0 +5,4 @@
h >= 12 && h < 17 ? "Good afternoon" :
h >= 17 && h < 20 ? "Good evening" :
h >= 21 && h < 24 ? "Good late night" :
"Have a good night";
miku4k (Migrated from github.com) commented 2025-12-01 05:16:23 -05:00
Copy link

Wait right, noon is specifically 12 for some. I meant the question as in "When would it say something like 'Good noon'?", because noon is in my head a time period approximately between 12 and 14, in the same way morning isn't specifically at 6 (because that's how it's used in german).

Wait right, noon is specifically 12 for some. I meant the question as in "When would it say something like 'Good noon'?", because noon is in my head a time period approximately between 12 and 14, in the same way morning isn't specifically at 6 (because that's how it's used in german).
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
katniny/Auride!125
No description provided.