marella/ctransformers
1
0
Fork 0
Code Issues 107 Pull requests 5 Projects Releases 30 Packages Wiki Activity Actions

Remove GGML_USE_CUBLAS when CT_HIPBLAS is defined #136

Open
muaiyadh wants to merge 1 commit from muaiyadh/main into main
pull from: muaiyadh/main
merge into: marella:main
Conversation 4 Commits 1 Files changed 1 -1
muaiyadh commented 2023-09-17 10:15:19 -04:00 (Migrated from github.com)
Copy link

Hi,

I couldn't install the library with HIPBLAS because of missing CUDA stuff.
Turns out there was an extra option for compiling with CUBLAS when CT_HIPBLAS is defined.

Also, should fix #134 and #135

Hi, I couldn't install the library with HIPBLAS because of missing CUDA stuff. Turns out there was an extra option for compiling with CUBLAS when CT_HIPBLAS is defined. Also, should fix #134 and #135
bugfixin commented 2023-09-17 16:34:28 -04:00 (Migrated from github.com)
Copy link

Trying this myself, it seems to work, thank you!

Trying this myself, it seems to work, thank you!
CrashTD commented 2023-09-18 06:19:30 -04:00 (Migrated from github.com)
Copy link

Still does not build for me. However, the log is now significant shorter.
https://gist.github.com/CrashTD/e3ef7d4901a22b7795e1618b196e3d36

maybe just a incompatibility with the still relatively new gfx1101?

Still does not build for me. However, the log is now significant shorter. https://gist.github.com/CrashTD/e3ef7d4901a22b7795e1618b196e3d36 maybe just a incompatibility with the still relatively new gfx1101?
bugfixin commented 2023-09-18 15:00:25 -04:00 (Migrated from github.com)
Copy link

Still does not build for me. However, the log is now significant shorter. https://gist.github.com/CrashTD/e3ef7d4901a22b7795e1618b196e3d36

maybe just a incompatibility with the still relatively new gfx1101?

It looks like your compilation is using the standard system compilers (cc and c++), try setting the environment variables CC="/opt/rocm/llvm/bin/clang" CXX="/opt/rocm/llvm/bin/clang++" (you can prepend that to the pip install command), e.g. CC="/opt/rocm/llvm/bin/clang" CXX="/opt/rocm/llvm/bin/clang++" CT_HIPBLAS=1 pip install ctransformers --no-binary ctransformers

> Still does not build for me. However, the log is now significant shorter. https://gist.github.com/CrashTD/e3ef7d4901a22b7795e1618b196e3d36 > > maybe just a incompatibility with the still relatively new gfx1101? It looks like your compilation is using the standard system compilers (cc and c++), try setting the environment variables `CC="/opt/rocm/llvm/bin/clang" CXX="/opt/rocm/llvm/bin/clang++" ` (you can prepend that to the pip install command), e.g. `CC="/opt/rocm/llvm/bin/clang" CXX="/opt/rocm/llvm/bin/clang++" CT_HIPBLAS=1 pip install ctransformers --no-binary ctransformers`
👍 1
CrashTD commented 2023-09-19 07:45:40 -04:00 (Migrated from github.com)
Copy link

It looks like your compilation is using the standard system compilers (cc and c++), ...

That in combination with the removal of the CUBLAS line fixed it. Thanks a lot!

> It looks like your compilation is using the standard system compilers (cc and c++), ... That in combination with the removal of the CUBLAS line fixed it. Thanks a lot!
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin muaiyadh/main:muaiyadh/main
git switch muaiyadh/main

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff muaiyadh/main
git switch muaiyadh/main
git rebase main
git switch main
git merge --ff-only muaiyadh/main
git switch muaiyadh/main
git rebase main
git switch main
git merge --no-ff muaiyadh/main
git switch main
git merge --squash muaiyadh/main
git switch main
git merge --ff-only muaiyadh/main
git switch main
git merge muaiyadh/main
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
marella/ctransformers!136
No description provided.