Break down llm_config.yaml into individual prompt template files

Copilot commented

2025-10-30 16:03:08 -04:00

(Migrated from github.com)

Summary: Break down llm_config.yaml into individual prompt files ✅

Successfully implemented the requested feature to break down the monolithic llm_config.yaml file into individual prompt template files for easier editing.

Changes Made:

Created tale/llm/prompt_templates/ directory
Identified prompt keys vs configuration keys in llm_config.yaml
Extracted 44 prompt template values to individual files in prompt_templates/
Updated llm_config.py to load prompts from individual files
Kept non-prompt config values in llm_config.yaml
Created comprehensive test suite to verify all prompts are loaded correctly
Ran existing tests to ensure no regression
Verified the code still works with the new structure
Added detailed documentation for the prompt templates
Fixed test_llm_io.py to use llm_config module

Implementation Details:

Files Created:

44 prompt template .txt files in tale/llm/prompt_templates/
tale/llm/prompt_templates/README.md with comprehensive documentation
tests/test_llm_config.py with 7 test cases

Files Modified:

tale/llm/llm_config.py - Enhanced to load prompts from individual files
llm_config.yaml - Simplified to contain only configuration values
tests/test_llm_io.py - Updated to use llm_config.load_config() instead of loading YAML directly

Key Design Decisions:

Filename (without .txt extension) becomes the dict key
Maintains the same llm_config.params dict structure
No breaking changes to consuming code
Configuration values stay in YAML, prompts in individual files

Testing:

✅ All new tests pass (7/7)
✅ All existing llm-related tests pass (30 tests including test_llm_io.py)
✅ Code review found no issues
✅ CodeQL security scan found no vulnerabilities

Benefits:

Easier Editing: Each prompt can now be edited in isolation without navigating a large YAML file
Better Version Control: Individual file changes are easier to track and review
Clear Organization: Prompts are categorized and documented
No Breaking Changes: Maintains backward compatibility with existing code
Maintainability: README explains structure and categorizes all prompts

Original prompt

This section details on the original issue you should resolve

<issue_title>break down llm_config.yaml into individual prompt files</issue_title>
<issue_description>currently llm_config.py loads various prompt templates used in the game from llm_config.yaml.

I'd like to change this so that each prompt is read from a separate file, to make editing easier.

The resulting files could be placed in a folder 'llm/prompt_templates'

the key for each prompt could be the name of the file. that way the resulting dict will be the same.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes neph1/LlamaTale#112

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

## Summary: Break down llm_config.yaml into individual prompt files ✅ Successfully implemented the requested feature to break down the monolithic `llm_config.yaml` file into individual prompt template files for easier editing. ### Changes Made: - [x] Created `tale/llm/prompt_templates/` directory - [x] Identified prompt keys vs configuration keys in llm_config.yaml - [x] Extracted 44 prompt template values to individual files in prompt_templates/ - [x] Updated llm_config.py to load prompts from individual files - [x] Kept non-prompt config values in llm_config.yaml - [x] Created comprehensive test suite to verify all prompts are loaded correctly - [x] Ran existing tests to ensure no regression - [x] Verified the code still works with the new structure - [x] Added detailed documentation for the prompt templates - [x] Fixed test_llm_io.py to use llm_config module ### Implementation Details: **Files Created:** - 44 prompt template `.txt` files in `tale/llm/prompt_templates/` - `tale/llm/prompt_templates/README.md` with comprehensive documentation - `tests/test_llm_config.py` with 7 test cases **Files Modified:** - `tale/llm/llm_config.py` - Enhanced to load prompts from individual files - `llm_config.yaml` - Simplified to contain only configuration values - `tests/test_llm_io.py` - Updated to use `llm_config.load_config()` instead of loading YAML directly **Key Design Decisions:** - Filename (without `.txt` extension) becomes the dict key - Maintains the same `llm_config.params` dict structure - No breaking changes to consuming code - Configuration values stay in YAML, prompts in individual files ### Testing: ✅ All new tests pass (7/7) ✅ All existing llm-related tests pass (30 tests including test_llm_io.py) ✅ Code review found no issues ✅ CodeQL security scan found no vulnerabilities ### Benefits: 1. **Easier Editing**: Each prompt can now be edited in isolation without navigating a large YAML file 2. **Better Version Control**: Individual file changes are easier to track and review 3. **Clear Organization**: Prompts are categorized and documented 4. **No Breaking Changes**: Maintains backward compatibility with existing code 5. **Maintainability**: README explains structure and categorizes all prompts  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>break down llm_config.yaml into individual prompt files</issue_title> > <issue_description>currently llm_config.py loads various prompt templates used in the game from llm_config.yaml. > > I'd like to change this so that each prompt is read from a separate file, to make editing easier. > > The resulting files could be placed in a folder 'llm/prompt_templates' > > the key for each prompt could be the name of the file. that way the resulting dict will be the same.</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> - Fixes neph1/LlamaTale#112  --- ✨ Let Copilot coding agent [set things up for you](https://github.com/neph1/LlamaTale/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo.

neph1 commented

2025-10-31 15:06:20 -04:00

(Migrated from github.com)

@copilot TestLlmIo.py uses the llm_config.yaml file, and those tests fail now. can you make it use the class instead? (llm_config.py)

Copilot commented

2025-10-31 15:10:06 -04:00

(Migrated from github.com)

@copilot TestLlmIo.py uses the llm_config.yaml file, and those tests fail now. can you make it use the class instead? (llm_config.py)

Fixed in commit 977c3cf. Updated test_llm_io.py to use llm_config.load_config() instead of loading the YAML file directly. All 11 tests in test_llm_io.py now pass.

> @copilot TestLlmIo.py uses the llm_config.yaml file, and those tests fail now. can you make it use the class instead? (llm_config.py) Fixed in commit 977c3cf. Updated `test_llm_io.py` to use `llm_config.load_config()` instead of loading the YAML file directly. All 11 tests in test_llm_io.py now pass.

Rows
Columns

Break down llm_config.yaml into individual prompt template files #113

Summary: Break down llm_config.yaml into individual prompt files ✅

Changes Made:

Implementation Details:

Testing:

Benefits:

Comments on the Issue (you are @copilot in this section)