projectdiscovery/nuclei-action
1
0
Fork 0
Code Issues Pull requests 6 Projects Releases 10 Packages Wiki Activity Actions

Add prefix to avoid reuse in github env #32

Merged
fguisso merged 2 commits from inputs into main 2022-04-19 09:45:34 -04:00
Conversation 6 Commits 2 Files changed 1 +26 -26
fguisso commented 2022-03-13 23:41:59 -04:00 (Migrated from github.com)
Copy link

This fixes a problem with concatenating PDActions.

You can test using naabu + nuclei or something another action, that parameters with same name export to GITHUB_ENV can't be updated, leaving us with the first input attribution, cause some errors.

This fixes a problem with concatenating PDActions. You can test using naabu + nuclei or something another action, that parameters with same name export to `GITHUB_ENV` can't be updated, leaving us with the first input attribution, cause some errors.
toufik-airane (Migrated from github.com) approved these changes 2022-03-15 12:41:56 -04:00
toufik-airane (Migrated from github.com) left a comment
Copy link

Nice catch. 👀
I approve the merge.

Thank you for your work! 👏

Nice catch. 👀 I approve the merge. Thank you for your work! 👏
fguisso commented 2022-03-16 01:08:11 -04:00 (Migrated from github.com)
Copy link

@toufik-airane probably we need to do that in all another PDActions, I can commit in all others repository if you accept this resolution.

I don't think this is the best solution, but probably a better solution is rewrite all actions using the javascript SDK for GitHub Actions. I had proposed this think about GITHUB_ENV in the past, then I compromise to update, but in a long-term.

@toufik-airane probably we need to do that in all another PDActions, I can commit in all others repository if you accept this resolution. I don't think this is the best solution, but probably a better solution is rewrite all actions using the javascript SDK for GitHub Actions. I had proposed this think about `GITHUB_ENV` in the past, then I compromise to update, but in a long-term.
toufik-airane commented 2022-03-19 18:24:45 -04:00 (Migrated from github.com)
Copy link

Hey @fguisso,

Great idea! It could be an awesome initiative to extend the longevity of the Actions.
What do you think about working on those changes in different branches and coordinating on Discord (Toufik Airane#1048)?

Regards.

Hey @fguisso, Great idea! It could be an awesome initiative to extend the longevity of the Actions. What do you think about working on those changes in different branches and coordinating on Discord (Toufik Airane#1048)? Regards.
👍 1
ehsandeep (Migrated from github.com) approved these changes 2022-04-19 09:45:18 -04:00
ehsandeep commented 2022-04-19 09:47:29 -04:00 (Migrated from github.com)
Copy link

Thank you, @fguisso, looks like we can make similar changes to other projects as well.

Thank you, @fguisso, looks like we can make similar changes to other projects as well.
👍 1
fguisso commented 2022-04-19 11:23:51 -04:00 (Migrated from github.com)
Copy link

@ehsandeep I'm studying the Github Actions Toolkit, it seems to be a fancier way to resolve this problem and avoid using GITHUB_ENV. I'll try to show you a refac until the weekend.

@ehsandeep I'm studying the Github Actions Toolkit, it seems to be a fancier way to resolve this problem and avoid using GITHUB_ENV. I'll try to show you a refac until the weekend.
👍 1 👀 1
Sign in to join this conversation.
Reviewers
No reviewers
toufik-airane
ehsandeep
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
projectdiscovery/nuclei-action!32
No description provided.