supermaven-inc/supermaven-nvim
1
0
Fork 0
Code Issues 56 Pull requests 13 Projects Releases Packages Wiki Activity Actions

feat(xdg spec): use $XDG_DATA_HOME by default #38

Merged
mirsella merged 1 commit from main into main 2024-09-24 12:06:22 -04:00
Conversation 5 Commits 1 Files changed 1 +8 -1
mirsella commented 2024-06-01 07:32:24 -04:00 (Migrated from github.com)
Copy link

Seems the sm-agent binary still create the ~/.supermaven/config.json, sm-agent will need to be updated upstream

close #37

Seems the sm-agent binary still create the ~/.supermaven/config.json, sm-agent will need to be updated upstream close #37
👍 3
flexagoon commented 2024-09-23 08:53:03 -04:00 (Migrated from github.com)
Copy link

@sm-victorw can you please merge this? Would also be great if sm-agent created the config in the proper location (~/.config/supermaven/config.json) instead of ~/.supermaven.

@sm-victorw can you please merge this? Would also be great if `sm-agent` created the config in the proper location (`~/.config/supermaven/config.json`) instead of `~/.supermaven`.
👍 4
sm-victorw (Migrated from github.com) reviewed 2024-09-24 11:20:16 -04:00
lua/supermaven-nvim/binary/binary_fetcher.lua
@ -134,7 +112,15 @@ end
function BinaryFetcher:local_binary_parent_path()
local home_dir = self.homedir
sm-victorw (Migrated from github.com) commented 2024-09-24 11:20:16 -04:00
Copy link

Won't home_dir always be nil? Later we attempt to concatenate this in dir = home_dir .. "/.supermaven"

Won't `home_dir` always be `nil`? Later we attempt to concatenate this in `dir = home_dir .. "/.supermaven"`
mirsella (Migrated from github.com) reviewed 2024-09-24 11:47:39 -04:00
lua/supermaven-nvim/binary/binary_fetcher.lua
@ -134,7 +112,15 @@ end
function BinaryFetcher:local_binary_parent_path()
local home_dir = self.homedir
mirsella (Migrated from github.com) commented 2024-09-24 11:47:39 -04:00
Copy link

totally sorry, i must have forgotten about changing to nil at the start of writing this

totally sorry, i must have forgotten about changing to nil at the start of writing this
mirsella (Migrated from github.com) reviewed 2024-09-24 11:57:00 -04:00
lua/supermaven-nvim/binary/binary_fetcher.lua
@ -134,7 +112,15 @@ end
function BinaryFetcher:local_binary_parent_path()
local home_dir = self.homedir
mirsella (Migrated from github.com) commented 2024-09-24 11:57:00 -04:00
Copy link

i undo my change to the initialization of self.homedir

i undo my change to the initialization of self.homedir
flexagoon commented 2024-09-24 12:41:16 -04:00 (Migrated from github.com)
Copy link

@sm-victorw since it's not open source and there's no way to contribute, can you tell if there are any plans to change sm-agent to use XDG location as well?

@sm-victorw since it's not open source and there's no way to contribute, can you tell if there are any plans to change sm-agent to use XDG location as well?
👍 4
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
supermaven-inc/supermaven-nvim!38
No description provided.