Fix disc splitting error

shinji257 commented

2025-03-01 00:59:23 -05:00

(Migrated from github.com)

Might not be the most elegant way but didn't see another option. Original code add the parent twice to the output template and failed to re-introduce the filename template portion that was stripped during the split. This adds that back and corrects the second joinpath() so it references that rather than the split. split renamed to path to indicate what it contains.

Googolplexed0 commented

2025-03-26 14:43:36 -04:00

(Migrated from github.com)

Implemented this in my fork as a one-liner:

if cls.get_split_album_discs():
            return str(PurePath(v).parent / 'Disc {disc_number}' / PurePath(v).name)

A bit cleaner but the same basic solution.

Implemented this in my [fork ](https://github.com/Googolplexed0/zotify) as a one-liner: ```python if cls.get_split_album_discs(): return str(PurePath(v).parent / 'Disc {disc_number}' / PurePath(v).name) ``` A bit cleaner but the same basic solution.

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin shinji257/disc_split_fix_zotify:shinji257/disc_split_fix_zotify

git switch shinji257/disc_split_fix_zotify

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff shinji257/disc_split_fix_zotify

git switch shinji257/disc_split_fix_zotify

git rebase main

git switch main

git merge --ff-only shinji257/disc_split_fix_zotify

git switch shinji257/disc_split_fix_zotify

git rebase main

git switch main

git merge --no-ff shinji257/disc_split_fix_zotify

git switch main

git merge --squash shinji257/disc_split_fix_zotify

git switch main

git merge --ff-only shinji257/disc_split_fix_zotify

git switch main

git merge shinji257/disc_split_fix_zotify

git push origin main

Rows
Columns

Fix disc splitting error #264

Checkout

Merge